From: Andreas Hindborg <a.hindborg@kernel.org>
To: "chentaotao" <chentaotao@didiglobal.com>
Cc: <boqun.feng@gmail.com>, <bjorn3_gh@protonmail.com>,
<rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<chentao325@qq.com>
Subject: Re: [PATCH] rust: block: Remove unnecessary comma in introduction
Date: Wed, 19 Mar 2025 12:04:25 +0100 [thread overview]
Message-ID: <8734f9i8na.fsf@kernel.org> (raw)
In-Reply-To: <20250319104412.50625-1-chentaotao@didiglobal.com> (chentaotao@didiglobal.com's message of "Wed, 19 Mar 2025 18:44:12 +0800")
"chentaotao" <chentaotao@didiglobal.com> writes:
> The comma after "methods" was not needed and has been removed for
> better readability and correctness.
>
> Signed-off-by: chentaotao <chentaotao@didiglobal.com>
> ---
> rust/kernel/block/mq.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/block/mq.rs b/rust/kernel/block/mq.rs
> index fb0f393c1..ee8f34f40 100644
> --- a/rust/kernel/block/mq.rs
> +++ b/rust/kernel/block/mq.rs
> @@ -23,7 +23,7 @@
> //! IO requests are passed to the driver as [`kernel::types::ARef<Request>`]
> //! instances. The `Request` type is a wrapper around the C `struct request`.
> //! The driver must mark end of processing by calling one of the
> -//! `Request::end`, methods. Failure to do so can lead to deadlock or timeout
> +//! `Request::end` methods. Failure to do so can lead to deadlock or timeout
> //! errors. Please note that the C function `blk_mq_start_request` is implicitly
> //! called when the request is queued with the driver.
> //!
Acked-by: Andreas Hindborg <a.hindborg@kernel.org>
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-03-19 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <j2rsp4Jty5pW-HOPkZX9ssG_ESGp1SAlh--rbhrhTQ6Z81f-tRt5SjBx42XS9jZo2vytk_ry-q4RYXMSD6B9xg==@protonmail.internalid>
2025-03-19 10:44 ` [PATCH] rust: block: Remove unnecessary comma in introduction chentaotao
2025-03-19 11:04 ` Andreas Hindborg [this message]
2025-03-21 4:55 ` Taotao chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734f9i8na.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=chentao325@qq.com \
--cc=chentaotao@didiglobal.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox