* [PATCH] rust: block: Remove unnecessary comma in introduction @ 2025-03-19 10:44 ` chentaotao 2025-03-19 11:04 ` Andreas Hindborg 0 siblings, 1 reply; 3+ messages in thread From: chentaotao @ 2025-03-19 10:44 UTC (permalink / raw) To: a.hindborg Cc: boqun.feng, bjorn3_gh, rust-for-linux, linux-kernel, chentao325, chentaotao The comma after "methods" was not needed and has been removed for better readability and correctness. Signed-off-by: chentaotao <chentaotao@didiglobal.com> --- rust/kernel/block/mq.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/kernel/block/mq.rs b/rust/kernel/block/mq.rs index fb0f393c1..ee8f34f40 100644 --- a/rust/kernel/block/mq.rs +++ b/rust/kernel/block/mq.rs @@ -23,7 +23,7 @@ //! IO requests are passed to the driver as [`kernel::types::ARef<Request>`] //! instances. The `Request` type is a wrapper around the C `struct request`. //! The driver must mark end of processing by calling one of the -//! `Request::end`, methods. Failure to do so can lead to deadlock or timeout +//! `Request::end` methods. Failure to do so can lead to deadlock or timeout //! errors. Please note that the C function `blk_mq_start_request` is implicitly //! called when the request is queued with the driver. //! -- 2.34.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: block: Remove unnecessary comma in introduction 2025-03-19 10:44 ` [PATCH] rust: block: Remove unnecessary comma in introduction chentaotao @ 2025-03-19 11:04 ` Andreas Hindborg 2025-03-21 4:55 ` Taotao chen 0 siblings, 1 reply; 3+ messages in thread From: Andreas Hindborg @ 2025-03-19 11:04 UTC (permalink / raw) To: chentaotao Cc: boqun.feng, bjorn3_gh, rust-for-linux, linux-kernel, chentao325 "chentaotao" <chentaotao@didiglobal.com> writes: > The comma after "methods" was not needed and has been removed for > better readability and correctness. > > Signed-off-by: chentaotao <chentaotao@didiglobal.com> > --- > rust/kernel/block/mq.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rust/kernel/block/mq.rs b/rust/kernel/block/mq.rs > index fb0f393c1..ee8f34f40 100644 > --- a/rust/kernel/block/mq.rs > +++ b/rust/kernel/block/mq.rs > @@ -23,7 +23,7 @@ > //! IO requests are passed to the driver as [`kernel::types::ARef<Request>`] > //! instances. The `Request` type is a wrapper around the C `struct request`. > //! The driver must mark end of processing by calling one of the > -//! `Request::end`, methods. Failure to do so can lead to deadlock or timeout > +//! `Request::end` methods. Failure to do so can lead to deadlock or timeout > //! errors. Please note that the C function `blk_mq_start_request` is implicitly > //! called when the request is queued with the driver. > //! Acked-by: Andreas Hindborg <a.hindborg@kernel.org> Best regards, Andreas Hindborg ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: block: Remove unnecessary comma in introduction 2025-03-19 11:04 ` Andreas Hindborg @ 2025-03-21 4:55 ` Taotao chen 0 siblings, 0 replies; 3+ messages in thread From: Taotao chen @ 2025-03-21 4:55 UTC (permalink / raw) To: a.hindborg Cc: bjorn3_gh, boqun.feng, chentao325, linux-kernel, rust-for-linux Hi, Andreas I realized that my previous commit message was incorrect — the comma removed was before "methods" not after. I will submit a v2 patch to correct this. Apologies for the mistake, and thank you for your time. Best regards, Chentaotao ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-21 4:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <j2rsp4Jty5pW-HOPkZX9ssG_ESGp1SAlh--rbhrhTQ6Z81f-tRt5SjBx42XS9jZo2vytk_ry-q4RYXMSD6B9xg==@protonmail.internalid>
2025-03-19 10:44 ` [PATCH] rust: block: Remove unnecessary comma in introduction chentaotao
2025-03-19 11:04 ` Andreas Hindborg
2025-03-21 4:55 ` Taotao chen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox