From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C5FF1E3DE5 for ; Mon, 20 Jan 2025 14:49:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737384554; cv=none; b=S4S5p/vIt3a5J0SSGUd+NjdV1M3PFoO6le/5Pqt1Iet4pFiy3NqM+SOjAXafv4123kcw32nEboidPa1PE8bnHJKoEkp8IJnkRTVsiMz/hskSDkO2Rksgy37KknO/hep8slBC9dc3spaHX4tZQTEUADD/gvqRPJ5OWcIU4Y/x1IQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737384554; c=relaxed/simple; bh=97VgZ9NoSF4UZ5T0NiQTXmNeNQczFmf/vzKxnh+EYp8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Hks6h9hIXPB/Yq9+mvWZGWFOQnNc2q2lb1dUG956D/gM72H5PXPbUin4FhgASPSEJnCiC8RNPX6CP/+I/J1HDbvC0y1stPewjYB2ks0VWJvf+8dEzyTEnNUhIKWZEWj+7WMijBncxooR0FD3PsPNbZOmBYhsnjzbZe8hvmmqpbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QdR7moei; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QdR7moei" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737384551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4P+fb643O89fnX7RFAR9mtJaP74zPr0dFsGYSLFpk5M=; b=QdR7moeizVqm5hLhAeo8wH8gHuyB7aY5vSykvRoxX7OQo6gZdD2bK5pBchdE8bQeJFrJ+m ubNqXWm9g7oAcn3iiOPqdXCYWCVGrbeLru7Z4oS4vCK5tvssBb/RT/cz1m7PphzT9jxIr6 htwy8SSLflJc3gfY36BsI8Ci4E171zM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-rUC7Rp0ePD-nqcYX5sr8wQ-1; Mon, 20 Jan 2025 09:49:09 -0500 X-MC-Unique: rUC7Rp0ePD-nqcYX5sr8wQ-1 X-Mimecast-MFC-AGG-ID: rUC7Rp0ePD-nqcYX5sr8wQ Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-38bf5ef17b2so2589629f8f.0 for ; Mon, 20 Jan 2025 06:49:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737384548; x=1737989348; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4P+fb643O89fnX7RFAR9mtJaP74zPr0dFsGYSLFpk5M=; b=YuIZW9jQ03oouUrVVNRXntfgDmTAPyMNpFTsYVzYhD0t+qZIE6vJ/ka+7hhhGZ0iHH 9WvJYGa7yrf2D6ga6CsJEg9urGYQSiY89gKj2WbfgOio2WS9dHYuMME63yPxjovXga+U EeQQlccwf4QNjCjsLUBJN+VvMCY7wnpikg1ZMcRWaY9BvsgdMwehOaJxX/ZXjVf4U8gC pCosyktOSAVGqm/7FcXpvSPKUhQLu7V1SxA2Lih2yg+LZXXwXZPhjedaDRwmdfDrFOmw jbmU7iTXY1X8rPtKHdjcHdLTsdqyddHcRP9BK3IuJcs7PmzHN6xI50weUKvs+Ix3lNZu O/BQ== X-Forwarded-Encrypted: i=1; AJvYcCWQ1EZjKF55RAVPBiaHIhBwpcCZAsa14IIxTiL0g5zL5MnzhPnFEVtLuEC8kUWt6/d3Pvk4W5Ekgrkc10M=@vger.kernel.org X-Gm-Message-State: AOJu0YxfNZC6JyXLyauUMWfacB6OA0Hvfw5UsJzMVPIfd10t1bfbPGa0 Iz3WnetGo3Yff+2nceND1g24YYkP96iibnF3+uoXEbssXa5j/dCkJ22pDMH94fG/OPtErcW79Io TuD7KOiPHA4gVvShWEI8um/oB9bFutwiZ5UWk+G/T6y5zdoKAP1WcaguIJnrYCA== X-Gm-Gg: ASbGncsYDJi74MVMukLAH0RNAcxwixnghnDg4QCD2pjR6yba3Um/0MJ37T/Y73wWgnd P8O3IZUEHeteL13g8Bb9dkhZBSjl9aYz1pI5H7FQA2orDoKdKXDtKKBWUrswpztrVGywV8tj7Bm F3WsLPX+Wk7Mr+w7bRuol9zuViHqQ2JCnj5n2HEQ8WYhbWtWX3MbbhMd+DY+eS74b75LYTaQYIh p4Nmx/8Bxo7UfIl5VJHktUdgyO0k4Pbk/sUD03PJXwjYokdxU3+3LrgYlmohs0Q X-Received: by 2002:a5d:4845:0:b0:386:857:cc54 with SMTP id ffacd0b85a97d-38bf5679b17mr9506987f8f.9.1737384548536; Mon, 20 Jan 2025 06:49:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IF7Xb6EfEx+VXZHCbB8PiN72WuCFAku8/mV3FWjy0SkkiH+AeBrYjkPr7K7Eqr7QXG6qPKkhg== X-Received: by 2002:a5d:4845:0:b0:386:857:cc54 with SMTP id ffacd0b85a97d-38bf5679b17mr9506969f8f.9.1737384548154; Mon, 20 Jan 2025 06:49:08 -0800 (PST) Received: from fedora (g2.ign.cz. [91.219.240.8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf327e213sm10562551f8f.81.2025.01.20.06.49.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 06:49:07 -0800 (PST) From: Vitaly Kuznetsov To: Sean Christopherson , Sean Christopherson , Paolo Bonzini , David Woodhouse , Paul Durrant Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+352e553a86e0d75f5120@syzkaller.appspotmail.com, Paul Durrant , David Woodhouse Subject: Re: [PATCH 09/10] KVM: x86: Setup Hyper-V TSC page before Xen PV clocks (during clock update) In-Reply-To: <20250118005552.2626804-10-seanjc@google.com> References: <20250118005552.2626804-1-seanjc@google.com> <20250118005552.2626804-10-seanjc@google.com> Date: Mon, 20 Jan 2025 15:49:06 +0100 Message-ID: <8734hd8rrx.fsf@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Sean Christopherson writes: > When updating paravirtual clocks, setup the Hyper-V TSC page before > Xen PV clocks. This will allow dropping xen_pvclock_tsc_unstable in favor > of simply clearing PVCLOCK_TSC_STABLE_BIT in the reference flags. > > Cc: Vitaly Kuznetsov > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/x86.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 9eabd70891dd..c68e7f7ba69d 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -3280,6 +3280,8 @@ static int kvm_guest_time_update(struct kvm_vcpu *v) > hv_clock.flags &= ~PVCLOCK_GUEST_STOPPED; > } > > + kvm_hv_setup_tsc_page(v->kvm, &hv_clock); > + > #ifdef CONFIG_KVM_XEN > if (vcpu->xen.vcpu_info_cache.active) > kvm_setup_guest_pvclock(&hv_clock, v, &vcpu->xen.vcpu_info_cache, > @@ -3289,7 +3291,6 @@ static int kvm_guest_time_update(struct kvm_vcpu *v) > kvm_setup_guest_pvclock(&hv_clock, v, &vcpu->xen.vcpu_time_info_cache, 0, > xen_pvclock_tsc_unstable); > #endif > - kvm_hv_setup_tsc_page(v->kvm, &hv_clock); > return 0; > } "No functional change detected". Reviewed-by: Vitaly Kuznetsov (What I'm wondering is if (from mostly theoretical PoV) it's OK to pass *some* of the PV clocks as stable and some as unstable to the same guest, i.e. if it would make sense to disable Hyper-V TSC page when KVM_XEN_HVM_CONFIG_PVCLOCK_TSC_UNSTABLE too. I don't know if anyone combines Xen and Hyper-V emulation capabilities for the same guest on KVM though.) -- Vitaly