From: Takashi Iwai <tiwai@suse.de>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-kselftest@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Shuah Khan <shuah@kernel.org>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-next] selftests/alsa: Fix circular dependency involving global-timer
Date: Fri, 20 Dec 2024 10:01:09 +0100 [thread overview]
Message-ID: <8734iirane.wl-tiwai@suse.de> (raw)
In-Reply-To: <20241218025931.914164-1-lizhijian@fujitsu.com>
On Wed, 18 Dec 2024 03:59:31 +0100,
Li Zhijian wrote:
>
> The pattern rule `$(OUTPUT)/%: %.c` inadvertently included a circular
> dependency on the global-timer target due to its inclusion in
> $(TEST_GEN_PROGS_EXTENDED). This resulted in a circular dependency
> warning during the build process.
>
> To resolve this, the dependency on $(TEST_GEN_PROGS_EXTENDED) has been
> replaced with an explicit dependency on $(OUTPUT)/libatest.so. This change
> ensures that libatest.so is built before any other targets that require it,
> without creating a circular dependency.
>
> This fix addresses the following warning:
>
> make[4]: Entering directory 'tools/testing/selftests/alsa'
> make[4]: Circular default_modconfig/kselftest/alsa/global-timer <- default_modconfig/kselftest/alsa/global-timer dependency dropped.
> make[4]: Nothing to be done for 'all'.
> make[4]: Leaving directory 'tools/testing/selftests/alsa'
>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: Shuah Khan <shuah@kernel.org>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2024-12-20 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 2:59 [PATCH for-next] selftests/alsa: Fix circular dependency involving global-timer Li Zhijian
2024-12-20 9:01 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734iirane.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox