[PATCH for-next] selftests/alsa: Fix circular dependency involving global-timer

[PATCH for-next] selftests/alsa: Fix circular dependency involving global-timer

[Li Zhijian]

The pattern rule `$(OUTPUT)/%: %.c` inadvertently included a circular
dependency on the global-timer target due to its inclusion in
$(TEST_GEN_PROGS_EXTENDED). This resulted in a circular dependency
warning during the build process.

To resolve this, the dependency on $(TEST_GEN_PROGS_EXTENDED) has been
replaced with an explicit dependency on $(OUTPUT)/libatest.so. This change
ensures that libatest.so is built before any other targets that require it,
without creating a circular dependency.

This fix addresses the following warning:

make[4]: Entering directory 'tools/testing/selftests/alsa'
make[4]: Circular default_modconfig/kselftest/alsa/global-timer <- default_modconfig/kselftest/alsa/global-timer dependency dropped.
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory 'tools/testing/selftests/alsa'

Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
Cc: linux-sound@vger.kernel.org
Cc: linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 tools/testing/selftests/alsa/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/alsa/Makefile b/tools/testing/selftests/alsa/Makefile
index 944279160fed..8dab90ad22bb 100644
--- a/tools/testing/selftests/alsa/Makefile
+++ b/tools/testing/selftests/alsa/Makefile
@@ -27,5 +27,5 @@ include ../lib.mk
 $(OUTPUT)/libatest.so: conf.c alsa-local.h
 	$(CC) $(CFLAGS) -shared -fPIC $< $(LDLIBS) -o $@
 
-$(OUTPUT)/%: %.c $(TEST_GEN_PROGS_EXTENDED) alsa-local.h
+$(OUTPUT)/%: %.c $(OUTPUT)/libatest.so alsa-local.h
 	$(CC) $(CFLAGS) $< $(LDLIBS) -latest -o $@
-- 
2.44.0

Re: [PATCH for-next] selftests/alsa: Fix circular dependency involving global-timer

[Takashi Iwai]

On Wed, 18 Dec 2024 03:59:31 +0100,
Li Zhijian wrote:
> 
> The pattern rule `$(OUTPUT)/%: %.c` inadvertently included a circular
> dependency on the global-timer target due to its inclusion in
> $(TEST_GEN_PROGS_EXTENDED). This resulted in a circular dependency
> warning during the build process.
> 
> To resolve this, the dependency on $(TEST_GEN_PROGS_EXTENDED) has been
> replaced with an explicit dependency on $(OUTPUT)/libatest.so. This change
> ensures that libatest.so is built before any other targets that require it,
> without creating a circular dependency.
> 
> This fix addresses the following warning:
> 
> make[4]: Entering directory 'tools/testing/selftests/alsa'
> make[4]: Circular default_modconfig/kselftest/alsa/global-timer <- default_modconfig/kselftest/alsa/global-timer dependency dropped.
> make[4]: Nothing to be done for 'all'.
> make[4]: Leaving directory 'tools/testing/selftests/alsa'
> 
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: Shuah Khan <shuah@kernel.org>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>

Applied now.  Thanks.


Takashi