From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Nir Lichtman <nir@lichtman.org>,
ebiederm@xmission.com, kees@kernel.org, brauner@kernel.org,
jack@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] exec: make printable macro more concise
Date: Mon, 18 Nov 2024 12:46:02 +0100 [thread overview]
Message-ID: <8734jon4sl.fsf@prevas.dk> (raw)
In-Reply-To: <CAHk-=wiMEpPZYDeF5ak8FToB_fw7pfjKhuJAcjLpjqMfCvvB7g@mail.gmail.com> (Linus Torvalds's message of "Sat, 16 Nov 2024 08:49:39 -0800")
On Sat, Nov 16 2024, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Fri, 15 Nov 2024 at 23:28, Al Viro <viro@zeniv.linux.org.uk> wrote:
>>
>> Now, whether that logics makes sense is a separate story;
>> that's before my time (1.3.60), so...
>
> Bah. The whole ctype stuff is a mess, partly because it's
> fundamentally a broken concept and depends on locale.
>
> The original ctype array was US-ASCII only, and at some point in the
> random past it got changed to be based on Latin1. Maybe indeed 1.3.60
> as you say, I didn't go digging around.
>
> And Latin1 is not only what I used to use, it's the "low range of
> unicode". So it makes *some* sense, but not a whole lot.
Yes, but the kernel's ctype is almost-but-not-quite latin1...
> It might be good to go back to US-ASCII just as a true lowest common
> denominator, because people who use the ctype macros almost certainly
> don't actually do it on unicode characters, they do it on bytes, and
> then UTF-8 will not actually DTRT with anything but US-ASCII anyway.
Exactly. But you said otherwise two years ago:
https://lore.kernel.org/lkml/3a2fa7c1-2e31-0479-761f-9c189f8ed8c3@rasmusvillemoes.dk/
Rasmus
next prev parent reply other threads:[~2024-11-18 11:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 6:12 [PATCH v2] exec: make printable macro more concise Nir Lichtman
2024-11-16 7:28 ` Al Viro
2024-11-16 16:49 ` Linus Torvalds
2024-11-16 17:23 ` Nir Lichtman
2024-11-16 22:06 ` Al Viro
2024-11-16 22:38 ` Nir Lichtman
2024-11-16 21:48 ` Al Viro
2024-11-18 11:46 ` Rasmus Villemoes [this message]
2024-11-18 17:07 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734jon4sl.fsf@prevas.dk \
--to=linux@rasmusvillemoes.dk \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nir@lichtman.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox