From: Kalle Valo <kvalo@kernel.org>
To: Karol Przybylski <karprzy7@gmail.com>
Cc: jjohnson@kernel.org, linux-wireless@vger.kernel.org,
ath12k@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: ath12k: Fix for out-of bound access error
Date: Mon, 21 Oct 2024 12:07:51 +0300 [thread overview]
Message-ID: <8734kpq0wo.fsf@kernel.org> (raw)
In-Reply-To: <20241015192155.3643363-1-karprzy7@gmail.com> (Karol Przybylski's message of "Tue, 15 Oct 2024 21:21:55 +0200")
Karol Przybylski <karprzy7@gmail.com> writes:
> Size of array passed to print_array_to_buf_index is decremented by 1
>
> Discovered in coverity scan, CID 1600742
>
> Signed-off-by: Karol Przybylski <karprzy7@gmail.com>
> ---
> drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> index b2be7dade79f..74767ba9ec2b 100644
> --- a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> +++ b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> @@ -1550,7 +1550,7 @@ ath12k_htt_print_tx_selfgen_ax_stats_tlv(const void *tag_buf, u16 tag_len,
> le32_to_cpu(htt_stats_buf->ax_mu_mimo_ndp));
> len += print_array_to_buf_index(buf, len, "ax_mu_mimo_brpollX_tried = ", 1,
> htt_stats_buf->ax_mu_mimo_brpoll,
> - ATH12K_HTT_TX_NUM_AX_MUMIMO_USER_STATS, "\n");
> + ATH12K_HTT_TX_NUM_AX_MUMIMO_USER_STATS-1, "\n");
A space before and after '-', please.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-10-21 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 19:21 [PATCH] wifi: ath12k: Fix for out-of bound access error Karol Przybylski
2024-10-21 9:07 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734kpq0wo.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=karprzy7@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox