public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anna-Maria Behnsen <anna-maria@linutronix.de>
To: Jinjie Ruan <ruanjinjie@huawei.com>,
	frederic@kernel.org, tglx@linutronix.de,
	richardcochran@gmail.com, kuba@kernel.org, ruanjinjie@huawei.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] posix-clock: Fix missing put_clock_desc()
Date: Fri, 18 Oct 2024 11:10:51 +0200	[thread overview]
Message-ID: <8734ktai90.fsf@somnus> (raw)
In-Reply-To: <20241017133249.3496025-1-ruanjinjie@huawei.com>

Hi,

Jinjie Ruan <ruanjinjie@huawei.com> writes:

> After get_clock_desc(), it should call put_clock_desc()
> if timespec64_valid_strict() check fails, put it ahead to avoid this.

Can you please rewrite the commit message so that it uses full sentences
and shortly explain the problem why get/put pair is required here? For
the subject I would propose to change it to: "posix-clock: Fix
unbalanced locking in pc_clock_settime()'.

The patch is no longer against next, as the change is already part of
linus tree.

The change itself looks good.

Thanks,

	Anna-Maria


      parent reply	other threads:[~2024-10-18  9:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17 13:32 [PATCH -next] posix-clock: Fix missing put_clock_desc() Jinjie Ruan
2024-10-17 14:09 ` Richard Cochran
2024-10-18  9:10 ` Anna-Maria Behnsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734ktai90.fsf@somnus \
    --to=anna-maria@linutronix.de \
    --cc=frederic@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=ruanjinjie@huawei.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox