From: Thomas Gleixner <tglx@linutronix.de>
To: Xavier <xavier_qy@163.com>,
anna-maria@linutronix.de, frederic@kernel.org,
j.granados@samsung.com, linux@weissschuh.net, mcgrof@kernel.org,
kees@kernel.org
Cc: linux-kernel@vger.kernel.org, Xavier <xavier_qy@163.com>
Subject: Re: [PATCH v1] Namespace: Optimize the namespace code
Date: Sat, 10 Aug 2024 10:53:19 +0200 [thread overview]
Message-ID: <8734ncu5c0.ffs@tglx> (raw)
In-Reply-To: <20240809121732.545807-1-xavier_qy@163.com>
On Fri, Aug 09 2024 at 20:17, Xavier wrote:
> Modify variable names in the function clone_time_ns to enhance
> readability, and optimize the memory release operation by placing
> it outside of the spin lock in alloc_ucounts.
Renaming variables is not an optimization. Don't do two things at once.
Also the rename is not adding any value. This code is about time
namespace so 'ns' is perfectly understandable.
Thanks,
tglx
next prev parent reply other threads:[~2024-08-10 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 12:17 [PATCH v1] Namespace: Optimize the namespace code Xavier
2024-08-10 8:53 ` Thomas Gleixner [this message]
2024-08-12 8:48 ` [PATCH v2] Ucount: Optimize the ucount code Xavier
2024-08-23 2:28 ` Xavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734ncu5c0.ffs@tglx \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=j.granados@samsung.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mcgrof@kernel.org \
--cc=xavier_qy@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox