Re: [PATCH v15 4/9] ext4: Reuse generic_ci_match for ci comparisons

Eric Biggers
2024-04-03T03:43:30Z

On Tue, Apr 02, 2024 at 06:48:37PM +0300, Eugen Hristev wrote:
> + ret = generic_ci_match(parent, fname->usr_fname,
> + &fname->cf_name, de->name,
> + de->name_len);
> + if (ret < 0) {
> + /*
> + * Treat comparison errors as not a match. The
> + * only case where it happens is on a disk
> + * corruption or ENOMEM.
> + */
> + return false;
> }
> - return !ext4_ci_compare(parent, fname->usr_fname, de->name,
> - de->name_len, false);
> + return ret;

Maybe write this as simply 'return ret > 0;'?

- Eric