From: Thomas Gleixner <tglx@linutronix.de>
To: Tianyang Zhang <zhangtianyang@loongson.cn>,
chenhuacai@kernel.org, jiaxun.yang@flygoat.com
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Baoqi Zhang <zhangbaoqi@loongson.cn>,
Biao Dong <dongbiao@loongson.cn>
Subject: Re: [PATCH V3] irqchip/loongson-pch-pic: Update interrupt registration policy
Date: Sat, 23 Mar 2024 21:05:17 +0100 [thread overview]
Message-ID: <8734sghfya.ffs@tglx> (raw)
In-Reply-To: <648e7f23-a2e0-ce8f-7c52-3bcda262de86@loongson.cn>
Tianyang!
On Fri, Mar 22 2024 at 18:14, Tianyang Zhang wrote:
Please do not top-post. See the 'Top-posting' chapter in:
https://people.kernel.org/tglx/notes-about-netiquette
> Regarding "WHY", my understanding is that a convincing reason is needed
> to explain the necessity of this patch.
Yes.
> If so, can the last paragraph "This will be more conducive to fully
> utilizing existing vectors to support more devices."
>
> be considered a simple explanation?
Kinda, but ideally you describe it in a way that there is context for
the reader. Like this:
The fixed mapping between the LS7A interrupt source and the HT
interrupt vector prevents the utilization of the full interrupt vector
space which limits the number of devices in a system
Replace the fixed mapping with a dynamic mapping which allocates a
vector when an interrupt source is set up. This avoids that unused
sources prevent vectors from being used for other devices.
See?
Thanks,
tglx
next prev parent reply other threads:[~2024-03-23 20:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 12:46 [PATCH V3] irqchip/loongson-pch-pic: Update interrupt registration policy Tianyang Zhang
2024-03-20 10:52 ` Thomas Gleixner
2024-03-22 10:14 ` Tianyang Zhang
2024-03-23 20:05 ` Thomas Gleixner [this message]
2024-03-25 1:54 ` Tianyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734sghfya.ffs@tglx \
--to=tglx@linutronix.de \
--cc=chenhuacai@kernel.org \
--cc=dongbiao@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=zhangbaoqi@loongson.cn \
--cc=zhangtianyang@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox