public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Min-Hua Chen <minhuadotchen@gmail.com>, Hu Haowen <src.res@email.cn>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	linux-doc-tw-discuss@lists.sourceforge.net,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Min-Hua Chen <minhuadotchen@gmail.com>
Subject: Re: [PATCH v3 0/3] convert TW translation sparse.txt to RST
Date: Tue, 03 Oct 2023 10:26:48 -0600	[thread overview]
Message-ID: <8734yrekon.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230902052512.12184-1-minhuadotchen@gmail.com>

Min-Hua Chen <minhuadotchen@gmail.com> writes:

> These patches move TW sparse.txt to TW dev-tools and
> convert TW sparse.txt to RST, based on [1].
> Add the RST to toctree [2].
>
> Randy said [1]:
> "
> it would be good if someone would update/modify this
> sparse.txt file to be in Documentation/translation/zh_TW/dev-tools/
> and convert it to sparse.rst (IMO).
> "
>
> [1] https://lore.kernel.org/lkml/bfab7c5b-e4d3-d8d9-afab-f43c0cdf26cf@infradead.org/
> [2] https://lore.kernel.org/lkml/87a5uxxqf3.fsf@meer.lwn.net/
>
>
>
> Min-Hua Chen (3):
>   docs: sparse: move TW sparse.txt to TW dev-tools
>   docs: sparse: convert sparse.txt to RST
>   docs: sparse: add sparse.rst to toctree
>
>  .../translations/zh_TW/dev-tools/index.rst    | 40 +++++++++++++++++++
>  .../{sparse.txt => dev-tools/sparse.rst}      |  2 +-
>  Documentation/translations/zh_TW/index.rst    |  2 +-
>  3 files changed, 42 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/translations/zh_TW/dev-tools/index.rst
>  rename Documentation/translations/zh_TW/{sparse.txt => dev-tools/sparse.rst} (99%)

So this series introduces a new warning:

WARNING: Unparseable C cross-reference: 'int'
Invalid C declaration: Expected identifier in nested name, got keyword: int [error at 3]
  int
  ---^

That is ... somewhat unhelpful.  I eventually tracked it down to this
piece in sparse.rst:

> 所以更簡單的辦法只要這樣做:
> 
> 	typedef int __bitwise pm_request_t;
> 
> 	#define PM_SUSPEND ((__force pm_request_t) 1)
> 	#define PM_RESUME ((__force pm_request_t) 2)
> 
> 現在你就有了嚴格的類型檢查所需要的所有基礎架構。

That needs to be a literal block to be parsed properly.  I have taken
the liberty of changing the first line above to:

> 所以更簡單的辦法只要這樣做::

...and the warning is gone.

Thus: series applied, but please properly build-test changes like this
in the future.

Thanks,

jon

  parent reply	other threads:[~2023-10-03 16:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-02  5:25 [PATCH v3 0/3] convert TW translation sparse.txt to RST Min-Hua Chen
2023-09-02  5:25 ` [PATCH v3 1/3] docs: sparse: move TW sparse.txt to TW dev-tools Min-Hua Chen
2023-09-02  5:25 ` [PATCH v3 2/3] docs: sparse: convert sparse.txt to RST Min-Hua Chen
2023-09-02  5:25 ` [PATCH v3 3/3] docs: sparse: add sparse.rst to toctree Min-Hua Chen
2023-10-03 16:26 ` Jonathan Corbet [this message]
2023-10-03 23:40   ` [PATCH v3 0/3] convert TW translation sparse.txt to RST Min-Hua Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734yrekon.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=linux-doc-tw-discuss@lists.sourceforge.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minhuadotchen@gmail.com \
    --cc=rdunlap@infradead.org \
    --cc=src.res@email.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox