public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Li zeming <zeming@nfschina.com>, jstultz@google.com, sboyd@kernel.org
Cc: linux-kernel@vger.kernel.org, Li zeming <zeming@nfschina.com>
Subject: Re: [PATCH] kernel: time: clocksource: Remove unnecessary ‘0’ values from ret
Date: Sun, 27 Aug 2023 20:11:08 +0200	[thread overview]
Message-ID: <8735049wzn.ffs@tglx> (raw)
In-Reply-To: <20230808173611.3066-1-zeming@nfschina.com>

On Wed, Aug 09 2023 at 01:36, Li zeming wrote:
> ret is assigned first, so it does not need to initialize the
> assignment.
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  kernel/time/clocksource.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index 91836b727cef..b4ad38812ef7 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -1289,7 +1289,7 @@ static int clocksource_unbind(struct clocksource *cs)
>   */
>  int clocksource_unregister(struct clocksource *cs)
>  {
> -	int ret = 0;
> +	int ret;
>  
>  	mutex_lock(&clocksource_mutex);
>  	if (!list_empty(&cs->list))

ret is only assigned a value when cs->list is not empty.

Can you please fix your analyzer or at least validate by inspection
whether your analyzer is correct?

While at it, please follow the instructions at:

  https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-submission-notes

Thanks,

        tglx

      parent reply	other threads:[~2023-08-27 18:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 17:36 [PATCH] kernel: time: clocksource: Remove unnecessary ‘0’ values from ret Li zeming
2023-08-07  3:29 ` kernel test robot
2023-08-27 18:11 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735049wzn.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=zeming@nfschina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox