From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFD41EB64DC for ; Tue, 18 Jul 2023 12:31:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229609AbjGRMbM (ORCPT ); Tue, 18 Jul 2023 08:31:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231420AbjGRMbH (ORCPT ); Tue, 18 Jul 2023 08:31:07 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FACF10E6; Tue, 18 Jul 2023 05:31:06 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F40C22195A; Tue, 18 Jul 2023 12:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689683465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KbjvdsHsS1PmNV4JGwm/IUUOXq5JvVmOTqBck+EzJEk=; b=RymDNfSaGPwdSqtX2PwhA7GLLqrSo7DFLn8fHZrcCEzTV4W0ZDaLLD+PJ1FRHPXu5SMgGc nCt9BxL8UUn0v7vXkgWrRRGXhKvEMpKGEpZhbTzb4J41+Iy1tapHlLc4WgIvZLfYjgCvd4 UxZ0GdERj5YY6gJk8lQL9178OX7pnZk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689683465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KbjvdsHsS1PmNV4JGwm/IUUOXq5JvVmOTqBck+EzJEk=; b=uLYybcIKIBzGtKobmZyQ05Z9kjWOjiLzlEKIt6RmL5oXEsuCP67rph5FANpRa2tXuOmTyU l4Wi0hxzHCF52gDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AEE8F134B0; Tue, 18 Jul 2023 12:31:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sCHNKQiGtmQUSAAAMHmgww (envelope-from ); Tue, 18 Jul 2023 12:31:04 +0000 Date: Tue, 18 Jul 2023 14:31:04 +0200 Message-ID: <87351lo0zb.wl-tiwai@suse.de> From: Takashi Iwai To: Amadeusz =?ISO-8859-2?Q?S=B3awi=F1ski?= Cc: Bjorn Helgaas , Mark Brown , Takashi Iwai , alsa-devel@alsa-project.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Pierre-Louis Bossart , Kai Vehmanen , Andy Shevchenko , Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , Hans de Goede Subject: Re: [PATCH v4 00/15] PCI: Define Intel PCI IDs and use them in drivers In-Reply-To: <20230717114511.484999-1-amadeuszx.slawinski@linux.intel.com> References: <20230717114511.484999-1-amadeuszx.slawinski@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Jul 2023 13:44:56 +0200, Amadeusz Sławiński wrote: > > PCI IDs for Intel HDA are duplicated across quite a few drivers, due to > various configurations and historical reasons. Currently almost all uses > of HDA PCI IDs have corresponding comment telling which platform it is. > Additionally there are some inconsistencies between drivers about which > ID corresponds to which device. > > Simplify things, by adding PCI IDs to global header and make use of them > in drivers. This allows for removal of comments by having IDs themselves > being self explanatory. Additionally it allows for removal of existing > inconsistencies by having one source of truth. > > Changes from v3: > - Fix double space in commit message title (Ilpo) > - Comment ACPI/PCI ID handling in Atom SST driver (Andy) > - Rebased once again and used --base this time (Andy) > > Changes from v2: > - Change CHV to BSW (Andy) > - Fix incorrectly rebased patches (Andy) > - Fix commit message and add suggestions from Andy to SST patch (Andy) > - Rebased on top of Linus tree commit: 4b810bf037e5 > > Changes from v1: > - Remove BXT-T PCI ID as it is not released (Andy) > - Reorder macros to start from pci_match_id() (Andy) > - Add comment about BXT->APL name change in commit messages (Andy) > - Use SST as part of macro name for DSP only devices (Andy) > - Add PCI IDs for all SST combinations (Andy) > > Changes from RFC: > - Sort Intel PCI IDs before adding new ones > - Fix ordering of new PCI IDs (Andy) > - Define all used Intel IDs (Andy) > - Add macros for controller type detection (Andy/Bjorn) > - Add set of patches changing to use above macro (Andy/Bjorn) > - Use PCI_DEVICE_DATA for Intel IDs in sound/pci/hda/hda_intel.c (Andy) > - Commit message wording (Andy) > - Remove unnecessary tabs (Andy) > > Amadeusz Sławiński (15): > PCI: Sort Intel PCI IDs by number > PCI: Add Intel Audio DSP devices to pci_ids.h > ASoC: SOF: Remove unused Broxton PCI ID > ALSA: Remove unused Broxton PCI ID > ALSA: hda: Add controller matching macros > ALSA: hda: Use global PCI match macro > ALSA: hda/i915: Use global PCI match macro > ASoC: Intel: Skylake: Use global PCI match macro > ALSA: intel-dsp-config: Convert to PCI device IDs defines > ALSA: hda: Convert to PCI device IDs defines > ASoC: Intel: avs: Convert to PCI device IDs defines > ASoC: Intel: avs: Convert to PCI device IDs defines > ASoC: Intel: Skylake: Convert to PCI device IDs defines > ASoC: SOF: Intel: Convert to PCI device IDs defines > ASoC: Intel: sst: Convert to PCI device IDs defines Now applied all to sound.git tree, merged to for-next branch. I pushed a signed tag hda-pci-ids including those (based on 6.5-rc2). git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/hda-pci-ids Feel free to merge to other trees. thanks, Takashi