From: Takashi Iwai <tiwai@suse.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Oswald Buddenhagen <oswald.buddenhagen@gmx.de>,
Arnd Bergmann <arnd@arndb.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: emu10k1: fix 64-bit integer division
Date: Wed, 17 May 2023 22:28:26 +0200 [thread overview]
Message-ID: <87353u1z4l.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230517201920.592909-1-arnd@kernel.org>
On Wed, 17 May 2023 22:19:17 +0200,
Arnd Bergmann wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Division of 64-bit values causes a link failure on 32-bit targets, depending
> on compiler version and target architecture:
>
> ERROR: modpost: "__divdi3" [sound/pci/emu10k1/snd-emu10k1.ko] undefined!
> ERROR: modpost: "__udivdi3" [sound/pci/emu10k1/snd-emu10k1.ko] undefined!
>
> Replace these with the safe div_u64() helpers.
>
> Fixes: bb5ceb43b7bf ("ALSA: emu10k1: fix non-zero mixer control defaults in highres mode")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Another fix patch was already submitted and merged:
https://lore.kernel.org/r/20230517164800.3650699-1-oswald.buddenhagen@gmx.de
Let me know if you still hit the issue with that patch.
thanks,
Takashi
prev parent reply other threads:[~2023-05-17 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 20:19 [PATCH] ALSA: emu10k1: fix 64-bit integer division Arnd Bergmann
2023-05-17 20:28 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87353u1z4l.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oswald.buddenhagen@gmx.de \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox