From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81610C77B6F for ; Tue, 11 Apr 2023 09:27:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229652AbjDKJ10 (ORCPT ); Tue, 11 Apr 2023 05:27:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjDKJ1Z (ORCPT ); Tue, 11 Apr 2023 05:27:25 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F303E1736; Tue, 11 Apr 2023 02:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681205244; x=1712741244; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=iI2t87/uhLKu3MKVrrkEskkv3w9ib+0I3zw/GUEjajw=; b=fA2ZYkmtZyAj46GgMkTyiTjPTIuCuEE9fAXfU0eqkdrBK5yrSfvChHDF 7kGfk6QekFmJKI8wnJqiv6ctceYwL6rr9V9tiY8Wi/M1+Z7Mdm07CiHxB V21+kaComAvW0dZJNWWEQI+lEPgTiGPQMbt+/2MPAAdycORi3SslG3//a 4poAt7YCizW1pIqB8+1xOSqIjwuWYnzlV+chsF6NCi2IAeFEhomwE5NaZ a3JMP8L2ajSAZrThyw9kyqcSe1qQiCVx3/MRmA9XrqAwwbhYd88Vwp7uU vlm7ykAwEW9xAhsWv9amvBCIiFALgJWp2ip1MtpksKlSH7BKWB9kzMzf2 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="429855761" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="429855761" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 02:27:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="718902535" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="718902535" Received: from tunterlu-mobl2.amr.corp.intel.com (HELO localhost) ([10.252.56.34]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 02:27:13 -0700 From: Jani Nikula To: Krzysztof Kozlowski , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Ben Skeggs , Karol Herbst , Lyude Paul , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org Cc: Krzysztof Kozlowski , Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org Subject: Re: [PATCH 1/2] drm/i915: constify pointers to hwmon_channel_info In-Reply-To: <20230407150031.79749-1-krzysztof.kozlowski@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230407150031.79749-1-krzysztof.kozlowski@linaro.org> Date: Tue, 11 Apr 2023 12:27:10 +0300 Message-ID: <873556epld.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 07 Apr 2023, Krzysztof Kozlowski wrote: > Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. > > Signed-off-by: Krzysztof Kozlowski > > --- > > This depends on hwmon core patch: > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/ > > Therefore I propose this should also go via hwmon tree. Thanks for doing this, I couldn't be bothered to follow through with it [1]. Acked-by: Jani Nikula [1] https://lore.kernel.org/r/20230309082841.400118-1-jani.nikula@intel.com > > Cc: Jean Delvare > Cc: Guenter Roeck > Cc: linux-hwmon@vger.kernel.org > --- > drivers/gpu/drm/i915/i915_hwmon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_hwmon.c b/drivers/gpu/drm/i915/i915_hwmon.c > index 596dd2c07010..87b527a54272 100644 > --- a/drivers/gpu/drm/i915/i915_hwmon.c > +++ b/drivers/gpu/drm/i915/i915_hwmon.c > @@ -267,7 +267,7 @@ static const struct attribute_group *hwm_groups[] = { > NULL > }; > > -static const struct hwmon_channel_info *hwm_info[] = { > +static const struct hwmon_channel_info * const hwm_info[] = { > HWMON_CHANNEL_INFO(in, HWMON_I_INPUT), > HWMON_CHANNEL_INFO(power, HWMON_P_MAX | HWMON_P_RATED_MAX | HWMON_P_CRIT), > HWMON_CHANNEL_INFO(energy, HWMON_E_INPUT), > @@ -275,7 +275,7 @@ static const struct hwmon_channel_info *hwm_info[] = { > NULL > }; > > -static const struct hwmon_channel_info *hwm_gt_info[] = { > +static const struct hwmon_channel_info * const hwm_gt_info[] = { > HWMON_CHANNEL_INFO(energy, HWMON_E_INPUT), > NULL > }; -- Jani Nikula, Intel Open Source Graphics Center