From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Rayyan Ansari <rayyan@ansari.sh>, linux-input@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
Rayyan Ansari <rayyan@ansari.sh>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: synaptics-rmi4: Fix SPI device ID
Date: Tue, 24 Jan 2023 11:07:00 +0100 [thread overview]
Message-ID: <8735802qm3.fsf@baylibre.com> (raw)
In-Reply-To: <20221219133717.1638496-1-rayyan@ansari.sh>
On Mon, Dec 19, 2022 at 13:37, Rayyan Ansari <rayyan@ansari.sh> wrote:
> Currently, the ID being set to "rmi4_spi" causes this warning:
> "SPI driver rmi4_spi has no spi_device_id for syna,rmi4-spi"
>
> Change the ID to rmi4-spi to stop this warning.
>
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> drivers/input/rmi4/rmi_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/rmi4/rmi_spi.c b/drivers/input/rmi4/rmi_spi.c
> index c82edda66b23..aa3a6a8544d4 100644
> --- a/drivers/input/rmi4/rmi_spi.c
> +++ b/drivers/input/rmi4/rmi_spi.c
> @@ -510,7 +510,7 @@ static const struct dev_pm_ops rmi_spi_pm = {
> };
>
> static const struct spi_device_id rmi_id[] = {
> - { "rmi4_spi", 0 },
> + { "rmi4-spi", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(spi, rmi_id);
> --
> 2.39.0
next prev parent reply other threads:[~2023-01-24 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 13:37 [PATCH] Input: synaptics-rmi4: Fix SPI device ID Rayyan Ansari
2023-01-24 10:07 ` Mattijs Korpershoek [this message]
2023-02-04 0:55 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735802qm3.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rayyan@ansari.sh \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox