Re: [PATCH RFC v7 08/23] dept: Apply sdt_might_sleep_strong() to PG_{locked,writeback} wait

Sergey Shtylyov
2023-01-09T09:14:48Z

On 1/9/23 6:33 AM, Byungchul Park wrote:

> Makes Dept able to track dependencies by PG_{locked,writeback} waits.
>
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
> mm/filemap.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/mm/filemap.c b/mm/filemap.c
> index c4d4ace..b013a5b 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
[...]
> @@ -1226,6 +1230,11 @@ static inline int folio_wait_bit_common(struct folio *folio, int bit_nr,
> unsigned long pflags;
> bool in_thrashing;
>
> + if (bit_nr == PG_locked)
> + sdt_might_sleep_strong(&PG_locked_map);
> + else if (bit_nr == PG_writeback)
> + sdt_might_sleep_strong(&PG_writeback_map);

Hm, this is asking to be a *switch* statement instead...

[...]

MBR, Sergey