From: Thomas Gleixner <tglx@linutronix.de>
To: Delyan Kratunov <delyank@fb.com>,
"peterz@infradead.org" <peterz@infradead.org>
Cc: "dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
"bigeasy@linutronix.de" <bigeasy@linutronix.de>,
"keescook@chromium.org" <keescook@chromium.org>,
"qais.yousef@arm.com" <qais.yousef@arm.com>,
Delyan Kratunov <delyank@fb.com>,
"andrii@kernel.org" <andrii@kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"adharmap@quicinc.com" <adharmap@quicinc.com>,
"alexei.starovoitov@gmail.com" <alexei.starovoitov@gmail.com>,
"andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>,
"ast@kernel.org" <ast@kernel.org>,
"Kenta.Tada@sony.com" <Kenta.Tada@sony.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bristot@redhat.com" <bristot@redhat.com>,
"ebiederm@xmission.com" <ebiederm@xmission.com>,
"mingo@kernel.org" <mingo@kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"ed.tsai@mediatek.com" <ed.tsai@mediatek.com>,
"legion@kernel.org" <legion@kernel.org>,
"acme@kernel.org" <acme@kernel.org>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"valentin.schneider@arm.com" <valentin.schneider@arm.com>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"namhyung@kernel.org" <namhyung@kernel.org>
Subject: Re: [PATCH v2] sched/tracing: append prev_state to tp args instead
Date: Thu, 12 May 2022 01:40:57 +0200 [thread overview]
Message-ID: <8735hfy6wm.ffs@tglx> (raw)
In-Reply-To: <c8a6930dfdd58a4a5755fc01732675472979732b.camel@fb.com>
On Wed, May 11 2022 at 18:28, Delyan Kratunov wrote:
> Commit fa2c3254d7cf (sched/tracing: Don't re-read p->state when emitting
> sched_switch event, 2022-01-20) added a new prev_state argument to the
> sched_switch tracepoint, before the prev task_struct pointer.
>
> This reordering of arguments broke BPF programs that use the raw
> tracepoint (e.g. tp_btf programs). The type of the second argument has
> changed and existing programs that assume a task_struct* argument
> (e.g. for bpf_task_storage access) will now fail to verify.
>
> If we instead append the new argument to the end, all existing programs
> would continue to work and can conditionally extract the prev_state
> argument on supported kernel versions.
If we instead? ... would continue to work?
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#changelog
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#submittingpatches
It's not too hard to actually follow documented rules. Something like
this:
"Undo the reordering and move the new argument last, which ensures
that all existing programs continue to work."
Hmm?
What's worse is that the changelog is missing a clear statement that
this is a one-time change which cannot be abused to turn tracepoints
into unmodifiable ABI as you stated in:
https://lore.kernel.org/lkml/CAEf4BzaEo+dxSRJZHQiXYrj-a3_B-eODZUxGh3HrnPjquMYFXQ@mail.gmail.com
Thanks,
tglx
next prev parent reply other threads:[~2022-05-11 23:41 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 16:25 [PATCH v3 0/2] sched/tracing: sched_switch prev_state reported as TASK_RUNNING when it's not Valentin Schneider
2022-01-20 16:25 ` [PATCH v3 1/2] sched/tracing: Don't re-read p->state when emitting sched_switch event Valentin Schneider
2022-03-01 15:24 ` [tip: sched/core] " tip-bot2 for Valentin Schneider
2022-03-04 16:13 ` Valentin Schneider
2022-03-08 18:02 ` Qais Yousef
2022-03-08 18:10 ` Greg KH
2022-03-08 18:51 ` Qais Yousef
2022-04-09 23:38 ` Qais Yousef
2022-04-10 22:06 ` Qais Yousef
2022-04-10 23:22 ` Holger Hoffstätte
2022-04-11 7:18 ` Holger Hoffstätte
2022-04-11 7:28 ` Greg KH
2022-04-11 8:05 ` Holger Hoffstätte
2022-04-11 13:23 ` Greg KH
2022-04-11 13:22 ` Greg KH
2022-04-11 21:06 ` Qais Yousef
2022-01-20 16:25 ` [PATCH v3 2/2] sched/tracing: Report TASK_RTLOCK_WAIT tasks as TASK_UNINTERRUPTIBLE Valentin Schneider
2022-03-01 15:24 ` [tip: sched/core] " tip-bot2 for Valentin Schneider
2022-04-09 23:42 ` [PATCH v3 2/2] " Qais Yousef
2022-04-10 6:14 ` Greg KH
2022-04-10 22:13 ` Qais Yousef
2022-04-11 13:20 ` Greg KH
2022-04-11 20:18 ` Qais Yousef
2022-01-21 17:15 ` [PATCH v3 0/2] sched/tracing: sched_switch prev_state reported as TASK_RUNNING when it's not Steven Rostedt
2022-02-27 15:33 ` Peter Zijlstra
2022-04-21 22:12 ` [PATCH] sched/tracing: append prev_state to tp args instead Delyan Kratunov
2022-04-22 10:13 ` Valentin Schneider
2022-04-22 11:09 ` Peter Zijlstra
2022-04-22 15:55 ` Steven Rostedt
2022-04-22 16:54 ` Andrii Nakryiko
2022-04-22 16:37 ` Andrii Nakryiko
2022-04-22 17:22 ` Delyan Kratunov
2022-04-22 18:30 ` Alexei Starovoitov
2022-04-26 12:28 ` Peter Zijlstra
2022-04-26 14:09 ` Qais Yousef
2022-04-26 15:54 ` Andrii Nakryiko
2022-04-27 10:34 ` Qais Yousef
2022-04-27 18:17 ` Andrii Nakryiko
2022-04-27 20:32 ` Alexei Starovoitov
2022-04-28 10:02 ` Qais Yousef
2022-05-09 19:32 ` Andrii Nakryiko
2022-05-10 7:01 ` Peter Zijlstra
2022-05-10 8:29 ` Peter Zijlstra
2022-05-10 14:31 ` Steven Rostedt
2022-05-11 18:28 ` [PATCH v2] " Delyan Kratunov
2022-05-11 19:10 ` Steven Rostedt
2022-05-11 22:45 ` [tip: sched/urgent] sched/tracing: Append " tip-bot2 for Delyan Kratunov
2022-05-11 23:40 ` Thomas Gleixner [this message]
2022-04-26 15:51 ` [PATCH] sched/tracing: append " Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735hfy6wm.ffs@tglx \
--to=tglx@linutronix.de \
--cc=Kenta.Tada@sony.com \
--cc=acme@kernel.org \
--cc=adharmap@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=delyank@fb.com \
--cc=dietmar.eggemann@arm.com \
--cc=ebiederm@xmission.com \
--cc=ed.tsai@mediatek.com \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=legion@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox