From: Kalle Valo <kvalo@kernel.org>
To: Hermes Zhang <chenhui.zhang@axis.com>
Cc: Arend van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, <kernel@axis.com>,
Hermes Zhang <chenhuiz@axis.com>,
<linux-wireless@vger.kernel.org>,
<brcm80211-dev-list.pdl@broadcom.com>,
<SHA-cyfmac-dev-list@infineon.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] brcmfmac: of: introduce new property to allow disable PNO
Date: Fri, 22 Apr 2022 08:59:43 +0300 [thread overview]
Message-ID: <8735i5odyo.fsf@kernel.org> (raw)
In-Reply-To: <20220422044419.3415842-1-chenhui.zhang@axis.com> (Hermes Zhang's message of "Fri, 22 Apr 2022 12:44:18 +0800")
Hermes Zhang <chenhui.zhang@axis.com> writes:
> From: Hermes Zhang <chenhuiz@axis.com>
>
> The PNO feature need to be disable for some scenario in different
> product. This commit introduce a new property to allow the
> product-specific toggling of this feature.
"some scenario"? That's not really helpful.
> Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
> ---
>
> Notes:
> Change property name to brcm,pno-disable
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> index 8623bde5eb70..121a195e4054 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> @@ -11,6 +11,7 @@
> #include "core.h"
> #include "common.h"
> #include "of.h"
> +#include "feature.h"
>
> static int brcmf_of_get_country_codes(struct device *dev,
> struct brcmf_mp_device *settings)
> @@ -102,6 +103,9 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
> if (bus_type != BRCMF_BUSTYPE_SDIO)
> return;
>
> + if (of_find_property(np, "brcm,pno-disable", NULL))
> + settings->feature_disable |= BIT(BRCMF_FEAT_PNO);
Is this DT property documented and acked by the Device Tree maintainers?
AFAIK DT is not supposed to be used as a software configuration
database.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-04-22 6:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 4:44 [PATCH v2] brcmfmac: of: introduce new property to allow disable PNO Hermes Zhang
2022-04-22 5:59 ` Kalle Valo [this message]
2022-04-24 19:13 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735i5odyo.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=chenhui.zhang@axis.com \
--cc=chenhuiz@axis.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kernel@axis.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox