From: Petr Machata <petrm@nvidia.com>
To: "Ziyang Xuan (William)" <william.xuanziyang@huawei.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Petr Machata <petrm@nvidia.com>,
<davem@davemloft.net>, <jgg@nvidia.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2] net: vlan: fix a UAF in vlan_dev_real_dev()
Date: Fri, 19 Nov 2021 11:07:01 +0100 [thread overview]
Message-ID: <8735nstq62.fsf@nvidia.com> (raw)
In-Reply-To: <c240e0e0-256c-698b-4a98-47490869faa3@huawei.com>
Ziyang Xuan (William) <william.xuanziyang@huawei.com> writes:
> I need some time to test my some ideas. And anyone has good ideas, please
> do not be stingy.
Jakub Kicinski <kuba@kernel.org> writes:
> I think we should move the dev_hold() to ndo_init(), otherwise it's
> hard to reason if destructor was invoked or not if
> register_netdevice() errors out.
That makes sense to me. We always put real_dev in the destructor, so we
should always hold it in the constructor...
next prev parent reply other threads:[~2021-11-19 10:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 2:12 [PATCH net v2] net: vlan: fix a UAF in vlan_dev_real_dev() Ziyang Xuan
2021-11-03 13:50 ` Jason Gunthorpe
2021-11-03 15:47 ` Jakub Kicinski
2021-11-03 16:11 ` Jason Gunthorpe
2021-11-03 14:30 ` patchwork-bot+netdevbpf
2021-11-15 17:04 ` Petr Machata
2021-11-15 17:49 ` Jakub Kicinski
2021-11-16 14:20 ` Petr Machata
2021-11-17 11:50 ` Petr Machata
2021-11-18 1:46 ` Ziyang Xuan (William)
2021-11-18 14:17 ` Jakub Kicinski
2021-11-19 3:29 ` Ziyang Xuan (William)
2021-11-19 10:07 ` Petr Machata [this message]
2021-11-23 9:01 ` Ziyang Xuan (William)
2021-11-23 12:35 ` Petr Machata
2021-11-25 11:33 ` Petr Machata
2021-11-26 1:48 ` Ziyang Xuan (William)
2021-11-19 3:04 ` Ziyang Xuan (William)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735nstq62.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=davem@davemloft.net \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=william.xuanziyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox