public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
	Liu Shixin <liushixin2@huawei.com>,
	Marco Elver <elver@google.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: don't select KFENCE on platform PPC_FSL_BOOK3E
Date: Wed, 13 Oct 2021 11:48:20 +1100	[thread overview]
Message-ID: <8735p57nsb.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <9c1ee778-b38b-3d41-37f3-5ea22dca063b@csgroup.eu>

Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Le 12/10/2021 à 08:24, Michael Ellerman a écrit :
>> Liu Shixin <liushixin2@huawei.com> writes:
>>> kindly ping.
>> 
>> I was under the impression you were trying to debug why it wasn't
>> working with Christophe.
>
> The investigation was a bit dormant to be honest since Liu confirmed 
> that neither KFENCE not DEBUG_PAGEALLOC works.

No worries. Sorry it fell to you to do the investigation.

> I now looked at the effort to make it work, and it is not trivial.
> At the time being, all linear space is mapped with pinned TLBs and 
> everything is setup for space 0, with space 1 being used temporarily 
> when doing heavy changes to space 0.
>
> We can't use standard pages for linear space on space 0 because we need 
> memory mapped at all time for exceptions (on booke exception run with 
> MMU on in space 0).
>
> In order to use standard pages, we'd need to reorganise the kernel to 
> have it run mostly in space 1 (for data at least) where we would map 
> almost everything with standard pages, and keep pinned TLB to map linear 
> space on space 0 for TLB miss exceptions. Then we'd do more or less like 
> book3s/32 and switch back into space 1 into other exceptions prolog.
>
> That could be good to do it as we could maybe have more code in common 
> with non booke 32 bits, but it is not a trivial job.
>
> So I suggest that for now, we just make KFENCE and DEBUG_PAGEALLOC 
> unselectable for booke/32 (e500 and 44x).

Yep seems reasonable.

cheers

  reply	other threads:[~2021-10-13  0:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24  6:39 [PATCH] powerpc: don't select KFENCE on platform PPC_FSL_BOOK3E Liu Shixin
2021-09-24  6:41 ` Christophe Leroy
2021-09-25  3:10   ` Liu Shixin
2021-09-28  3:06   ` Liu Shixin
2021-10-12  1:43 ` Liu Shixin
2021-10-12  5:41   ` LEROY Christophe
2021-10-12  6:24   ` Michael Ellerman
2021-10-12 17:28     ` Christophe Leroy
2021-10-13  0:48       ` Michael Ellerman [this message]
2021-10-13  8:16         ` Christophe Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735p57nsb.fsf@mpe.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=elver@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=liushixin2@huawei.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox