Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel tree

Manasi Navare
2018-11-07T00:05:02Z

On Tue, Nov 06, 2018 at 04:00:34PM -0800, Rodrigo Vivi wrote:
> On Wed, Nov 07, 2018 at 06:59:29AM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commit
> >
> > 35b876db4a42 ("drm/i915/dsc: Add slice_row_per_frame in DSC PPS programming")
> >
> > is missing a Signed-off-by from its committer.
>
> It seems the tag "Suggested-by:" tricked out our maintainer tools.

Hmm yea that makes sense since it did have suggested-by: me (committer)
so it skipped adding my sign-off.

Thanks for catching this and fixing it in tools.

Manasi

>
> from dim:
>
> # check for committer sign-off
> if ! git show -s $sha1 | grep -qi "S.*-by:.*$committer" ; then
>
> -----
>
> I will send a patch to our tools to spell signed-off-by directly.
>
> Thanks for reporting this out.
> Rodrigo.
>
> >
> > --
> > Cheers,
> > Stephen Rothwell
>
>
>
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx