Re: [PATCH v19 7/7] ptp: arm/arm64: Enable ptp_kvm for arm/arm64

Marc Zyngier
2021-04-17T09:05:34Z

On Sat, 17 Apr 2021 09:42:37 +0100,
Zenghui Yu <yuzenghui@huawei.com> wrote:
>
> On 2021/3/30 22:54, Marc Zyngier wrote:
> > +int kvm_arch_ptp_init(void)
> > +{
> > + int ret;
> > +
> > + ret = kvm_arm_hyp_service_available(ARM_SMCCC_KVM_FUNC_PTP);
> > + if (ret <= 0)
>
> kvm_arm_hyp_service_available() returns boolean. Maybe write as ?
>
> bool ret;
>
> ret = kvm_arm_hyp_service_available();
> if (!ret)
> return -ENODEV;

Fixed in 300bb1fe7671, as previously reported by Dan Carpenter in [1].

Thanks,

M.

https://lore.kernel.org/r/20210331043704.GG2065@kadam

--
Without deviation from the norm, progress is not possible.