From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Lutomirski <luto@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>, KVM <kvm@vger.kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>
Subject: Re: [patch 2/2] x86/kvm: Sanitize kvm_async_pf_task_wait()
Date: Sat, 07 Mar 2020 21:08:56 +0100 [thread overview]
Message-ID: <8736ak9bc7.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CALCETrXpW5TYRNu2hMXt=fGC8EOh7WVqffCzS5GrwApC1inTzw@mail.gmail.com>
Andy Lutomirski <luto@kernel.org> writes:
> On Sat, Mar 7, 2020 at 7:52 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>> WHAT? That's fundamentally broken. Can you point me to the code in
>> question?
>
> I think Paolo said so in a different thread, but I can't Let me see if
> I can find it:
>
> kvm_pv_enable_async_pf()
> kvm_clear_async_pf_completion_queue()
>
> but that doesn't actually seem to send #PF. So maybe I'm wrong.
>
> I will admit that, even after reading the host code a few times, I'm
> also not convinced that wakeups don't get swallowed on occasion if
> they would have been delivered at times when it's illegal.
I gave up trying to decode it. I wait for the kvm wizards to answer all
our nasty questions :)
Thanks,
tglx
prev parent reply other threads:[~2020-03-07 20:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 23:42 [patch 0/2] x86/kvm: Sanitize async page fault Thomas Gleixner
2020-03-06 23:42 ` [patch 1/2] x86/kvm: Handle async page faults directly through do_page_fault() Thomas Gleixner
2020-03-17 8:47 ` [x86/kvm] aec3011ae9: WARNING:at_arch/x86/kernel/kvm.c:#kvm_guest_init kernel test robot
2020-03-06 23:42 ` [patch 2/2] x86/kvm: Sanitize kvm_async_pf_task_wait() Thomas Gleixner
2020-03-07 0:22 ` Paul E. McKenney
2020-03-07 1:02 ` Thomas Gleixner
2020-03-07 3:48 ` Paul E. McKenney
2020-03-07 2:18 ` Andy Lutomirski
2020-03-07 10:01 ` Thomas Gleixner
2020-03-07 15:10 ` Andy Lutomirski
2020-03-07 15:51 ` Andy Lutomirski
2020-03-07 19:18 ` Thomas Gleixner
2020-03-07 19:30 ` Andy Lutomirski
2020-03-07 15:52 ` Thomas Gleixner
2020-03-07 16:06 ` Andy Lutomirski
2020-03-07 20:08 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736ak9bc7.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox