From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 455B0C35240 for ; Sun, 26 Jan 2020 08:19:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14D2E2071A for ; Sun, 26 Jan 2020 08:19:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729037AbgAZIJ7 (ORCPT ); Sun, 26 Jan 2020 03:09:59 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:45173 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726438AbgAZIJ6 (ORCPT ); Sun, 26 Jan 2020 03:09:58 -0500 Received: from p5b06da22.dip0.t-ipconnect.de ([91.6.218.34] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1ivczT-0004Yw-Fn; Sun, 26 Jan 2020 09:09:55 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 7F883100490; Sun, 26 Jan 2020 09:09:54 +0100 (CET) From: Thomas Gleixner To: Jacob Pan , LKML Cc: Evan Green Subject: Re: [PATCH v2] PCI/MSI: Avoid torn updates to MSI pairs In-Reply-To: <1579977166-63618-1-git-send-email-jacob.jun.pan@linux.intel.com> References: <20200117162444.v2.1.I9c7e72144ef639cc135ea33ef332852a6b33730f@changeid> <1579977166-63618-1-git-send-email-jacob.jun.pan@linux.intel.com> Date: Sun, 26 Jan 2020 09:09:54 +0100 Message-ID: <8736c2myel.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jacob Pan writes: > It seems we could avoid force_retrigger once IR is turned on. I have tried > this patch with IR turned on, still seeing force_retrigger=1 for MSIs w/o > masking. Yes. That patch was a POC and surely not a final solution. Aside of that I'm still looking into a solution to avoid that which does not involve horrible locking and tons of scary code. Thanks, tglx