Re: [PATCH v2] x86/boot/KASLR: Fix unused variable warning

Thomas Gleixner
2020-01-10T13:13:43Z

Zhenzhong Duan <zhenzhong.duan@gmail.com> writes:

> On Fri, Jan 10, 2020 at 5:00 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>>
>> Zhenzhong Duan <zhenzhong.duan@gmail.com> writes:
>>
>> > Local variable 'i' is referenced only when CONFIG_MEMORY_HOTREMOVE and
>> > CONFIG_ACPI are defined, but definition of variable 'i' is out of guard.
>> > If any of the two macros is undefined, below warning triggers during
>> > build, fix it by moving 'i' in the guard.
>> >
>> > arch/x86/boot/compressed/kaslr.c:698:6: warning: unused variable ‘i’ [-Wunused-variable]
>> >
>> > Also use true/false instead of 1/0 for boolean return.
>>
>> No. This is not the scope of the unused variable issue. This want's to
>> be a separate patch.
>
> I'm trying to combine trivial changes into one, so you maintainers
> don't mind to pick two trivial patches? :)

See Documentation/process/submitting-patches.rst:

Solve only one problem per patch.

Thanks,

tglx