Re: [PATCH 4/5] drm/msm/dsi: get the clocks into OFF state at init

Jeffrey Hugo
2019-07-01T18:37:52Z

On 6/30/2019 9:01 AM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Do an extra enable/disable cycle at init, to get the clks into disabled
> state in case bootloader left them enabled.
>
> In case they were already enabled, the clk_prepare_enable() has no real
> effect, other than getting the enable_count/prepare_count into the right
> state so that we can disable clocks in the correct order. This way we
> avoid having stuck clocks when we later want to do a modeset and set the
> clock rates.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 18 +++++++++++++++---
> drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 1 +
> 2 files changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c
> index aabab6311043..d0172d8db882 100644
> --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c
> +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c
> @@ -354,6 +354,7 @@ static int dsi_pll_10nm_lock_status(struct dsi_pll_10nm *pll)
> if (rc)
> pr_err("DSI PLL(%d) lock failed, status=0x%08x\n",
> pll->id, status);
> +rc = 0; // HACK, this will fail if PLL already running..

Umm, why? Is this intentional?

--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.