From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B400EC28CC1 for ; Sat, 1 Jun 2019 20:21:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89BD627293 for ; Sat, 1 Jun 2019 20:21:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726652AbfFAUVd (ORCPT ); Sat, 1 Jun 2019 16:21:33 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:60179 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbfFAUVd (ORCPT ); Sat, 1 Jun 2019 16:21:33 -0400 Received: from tarshish (unknown [10.0.8.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id F354044077F; Sat, 1 Jun 2019 23:21:11 +0300 (IDT) References: <20190531133733.16243-1-wangkefeng.wang@huawei.com> User-agent: mu4e 1.0; emacs 26.1 From: Baruch Siach To: Kefeng Wang Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Hulk Robot Subject: Re: [PATCH] tty/serial: digicolor: Fix digicolor-usart already registered warning In-reply-to: <20190531133733.16243-1-wangkefeng.wang@huawei.com> Date: Sat, 01 Jun 2019 23:21:28 +0300 Message-ID: <8736ktoy47.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kefeng, On Fri, May 31 2019, Kefeng Wang wrote: > When modprobe/rmmod/modprobe module, if platform_driver_register() fails, > the kernel complained, > > proc_dir_entry 'driver/digicolor-usart' already registered > WARNING: CPU: 1 PID: 5636 at fs/proc/generic.c:360 proc_register+0x19d/0x270 > > Fix this by adding uart_unregister_driver() when platform_driver_register() fails. > > Reported-by: Hulk Robot > Signed-off-by: Kefeng Wang Acked-by: Baruch Siach Thanks, baruch > --- > drivers/tty/serial/digicolor-usart.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/digicolor-usart.c b/drivers/tty/serial/digicolor-usart.c > index f460cca139e2..13ac36e2da4f 100644 > --- a/drivers/tty/serial/digicolor-usart.c > +++ b/drivers/tty/serial/digicolor-usart.c > @@ -541,7 +541,11 @@ static int __init digicolor_uart_init(void) > if (ret) > return ret; > > - return platform_driver_register(&digicolor_uart_platform); > + ret = platform_driver_register(&digicolor_uart_platform); > + if (ret) > + uart_unregister_driver(&digicolor_uart); > + > + return ret; > } > module_init(digicolor_uart_init); -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -