* [PATCH] clk: armada-370: fix refcount leak in a370_clk_init()
@ 2018-12-26 13:36 Yangtao Li
2018-12-26 15:42 ` Gregory CLEMENT
2018-12-28 19:46 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Yangtao Li @ 2018-12-26 13:36 UTC (permalink / raw)
To: mturquette, sboyd, gregory.clement; +Cc: linux-clk, linux-kernel, Yangtao Li
The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/clk/mvebu/armada-370.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/mvebu/armada-370.c b/drivers/clk/mvebu/armada-370.c
index 7dedfaa6e152..5c6bbee396b3 100644
--- a/drivers/clk/mvebu/armada-370.c
+++ b/drivers/clk/mvebu/armada-370.c
@@ -175,8 +175,10 @@ static void __init a370_clk_init(struct device_node *np)
mvebu_coreclk_setup(np, &a370_coreclks);
- if (cgnp)
+ if (cgnp) {
mvebu_clk_gating_setup(cgnp, a370_gating_desc);
+ of_node_put(cgnp);
+ }
}
CLK_OF_DECLARE(a370_clk, "marvell,armada-370-core-clock", a370_clk_init);
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: armada-370: fix refcount leak in a370_clk_init()
2018-12-26 13:36 [PATCH] clk: armada-370: fix refcount leak in a370_clk_init() Yangtao Li
@ 2018-12-26 15:42 ` Gregory CLEMENT
2018-12-28 19:46 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Gregory CLEMENT @ 2018-12-26 15:42 UTC (permalink / raw)
To: Yangtao Li; +Cc: mturquette, sboyd, linux-clk, linux-kernel
Hi Yangtao,
On mer., déc. 26 2018, Yangtao Li <tiny.windzz@gmail.com> wrote:
> The of_find_compatible_node() returns a node pointer with refcount
> incremented, but there is the lack of use of the of_node_put() when
> done. Add the missing of_node_put() to release the refcount.
Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Thanks,
Gregory
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/clk/mvebu/armada-370.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/mvebu/armada-370.c b/drivers/clk/mvebu/armada-370.c
> index 7dedfaa6e152..5c6bbee396b3 100644
> --- a/drivers/clk/mvebu/armada-370.c
> +++ b/drivers/clk/mvebu/armada-370.c
> @@ -175,8 +175,10 @@ static void __init a370_clk_init(struct device_node *np)
>
> mvebu_coreclk_setup(np, &a370_coreclks);
>
> - if (cgnp)
> + if (cgnp) {
> mvebu_clk_gating_setup(cgnp, a370_gating_desc);
> + of_node_put(cgnp);
> + }
> }
> CLK_OF_DECLARE(a370_clk, "marvell,armada-370-core-clock", a370_clk_init);
>
> --
> 2.17.0
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: armada-370: fix refcount leak in a370_clk_init()
2018-12-26 13:36 [PATCH] clk: armada-370: fix refcount leak in a370_clk_init() Yangtao Li
2018-12-26 15:42 ` Gregory CLEMENT
@ 2018-12-28 19:46 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2018-12-28 19:46 UTC (permalink / raw)
To: Yangtao Li, gregory.clement, mturquette
Cc: linux-clk, linux-kernel, Yangtao Li
Quoting Yangtao Li (2018-12-26 05:36:58)
> The of_find_compatible_node() returns a node pointer with refcount
> incremented, but there is the lack of use of the of_node_put() when
> done. Add the missing of_node_put() to release the refcount.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-28 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-26 13:36 [PATCH] clk: armada-370: fix refcount leak in a370_clk_init() Yangtao Li
2018-12-26 15:42 ` Gregory CLEMENT
2018-12-28 19:46 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox