From: Kalle Valo <kvalo@codeaurora.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <simon@thekelleys.org.uk>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
<davem@davemloft.net>, <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2] atmel: using strlcpy() to avoid possible buffer overflows
Date: Mon, 02 Jul 2018 17:40:14 +0300 [thread overview]
Message-ID: <8736x1snu9.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180630063341.9900-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Sat, 30 Jun 2018 14:33:41 +0800")
YueHaibing <yuehaibing@huawei.com> writes:
> 'firmware' is a module param which may been longer than firmware_id,
> so using strlcpy() to guard against overflows. Also priv is allocated
> with zeroed memory,no need to set firmware_id[0] to '\0'.
>
> v1 -> v2: remove priv->firmware_id[0] = '\0';
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/wireless/atmel/atmel.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
The changelog should be after "---" line. I can fix it this time, but in
the future please use the correct location.
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
--
Kalle Valo
next prev parent reply other threads:[~2018-07-02 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 6:33 [PATCH v2] atmel: using strlcpy() to avoid possible buffer overflows YueHaibing
2018-07-02 14:40 ` Kalle Valo [this message]
2018-07-03 1:48 ` YueHaibing
2018-07-04 15:15 ` [v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736x1snu9.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon@thekelleys.org.uk \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox