From: Paulo Alcantara <paulo@paulo.ac>
To: Arnd Bergmann <arnd@arndb.de>, Steve French <sfrench@samba.org>
Cc: y2038@lists.linaro.org, Arnd Bergmann <arnd@arndb.de>,
Aurelien Aptel <aaptel@suse.com>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Pavel Shilovsky <pshilov@microsoft.com>,
Long Li <longli@microsoft.com>, Kees Cook <keescook@chromium.org>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cifs: use timespec64 internally
Date: Tue, 19 Jun 2018 13:36:31 -0300 [thread overview]
Message-ID: <8736xibunk.fsf@paulo.ac> (raw)
In-Reply-To: <20180619153255.3634720-1-arnd@arndb.de>
Arnd Bergmann <arnd@arndb.de> writes:
> In cifs, the timestamps are stored in memory in the cifs_fattr structure,
> which uses the deprecated 'timespec' structure. Now that the VFS code
> has moved on to 'timespec64', the next step is to change over the fattr
> as well.
>
> This also makes 32-bit and 64-bit systems behave the same way, and
> no longer overflow the 32-bit time_t in year 2038.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> fs/cifs/cifsencrypt.c | 4 ++--
> fs/cifs/cifsglob.h | 6 +++---
> fs/cifs/cifsproto.h | 6 +++---
> fs/cifs/cifssmb.c | 12 ++++++------
> fs/cifs/inode.c | 34 ++++++++++++++++------------------
> fs/cifs/netmisc.c | 19 ++++++++++---------
> 6 files changed, 40 insertions(+), 41 deletions(-)
Reviewed-by: Paulo Alcantara <palcantara@suse.de>
Thanks
Paulo
prev parent reply other threads:[~2018-06-19 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 15:27 [PATCH 1/2] cifs: use timespec64 internally Arnd Bergmann
2018-06-19 15:27 ` [PATCH 2/2] cifs: use 64-bit timestamps for fscache Arnd Bergmann
2018-06-19 16:36 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736xibunk.fsf@paulo.ac \
--to=paulo@paulo.ac \
--cc=aaptel@suse.com \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=lsahlber@redhat.com \
--cc=pshilov@microsoft.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox