From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932217AbdJYCc5 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Oct 2017 22:32:57 -0400
Received: from mga05.intel.com ([192.55.52.43]:54392 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751672AbdJYCcy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Oct 2017 22:32:54 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,430,1503385200"; 
   d="scan'208";a="166703604"
From: "Huang\, Ying" <ying.huang@intel.com>
To: Minchan Kim <minchan@kernel.org>
Cc: "Huang\, Ying" <ying.huang@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, Tim Chen <tim.c.chen@linux.intel.com>,
        "Michal Hocko" <mhocko@suse.com>, <stable@vger.kernel.org>,
        Christian Kujau <lists@nerdbynature.de>
Subject: Re: [PATCH -mm] mm, swap: Fix false error message in __swp_swapcount()
References: <20171024024700.23679-1-ying.huang@intel.com>
        <20171024201708.GA25022@bgram>
Date: Wed, 25 Oct 2017 10:32:52 +0800
In-Reply-To: <20171024201708.GA25022@bgram> (Minchan Kim's message of "Wed, 25
        Oct 2017 05:17:08 +0900")
Message-ID: <8737686jor.fsf@yhuang-dev.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Minchan Kim <minchan@kernel.org> writes:

> On Tue, Oct 24, 2017 at 10:47:00AM +0800, Huang, Ying wrote:
>> From: Ying Huang <ying.huang@intel.com>
>> 
>> __swp_swapcount() is used in __read_swap_cache_async().  Where the
>> invalid swap entry (offset > max) may be supplied during swap
>> readahead.  But __swp_swapcount() will print error message for these
>> expected invalid swap entry as below, which will make the users
>> confusing.
>> 
>>   swap_info_get: Bad swap offset entry 0200f8a7
>> 
>> So the swap entry checking code in __swp_swapcount() is changed to
>> avoid printing error message for it.  To avoid to duplicate code with
>> __swap_duplicate(), a new helper function named
>> __swap_info_get_silence() is added and invoked in both places.
>
> It's the problem caused by readahead, not __swap_info_get which is low-end
> primitive function. Instead, please fix high-end swapin_readahead to limit
> to last valid block as handling to avoid swap header which is special case,
> too.

Yes.  You are right, will send the new version.

Best Regards,
Huang, Ying