From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Makefile: Another fix for stackprotector _AUTO mode
Date: Sun, 15 Oct 2017 11:05:27 +0200 [thread overview]
Message-ID: <87376kok6g.fsf@belgarion.home> (raw)
In-Reply-To: <20171015034218.GA57631@beast> (Kees Cook's message of "Sat, 14 Oct 2017 20:42:18 -0700")
Kees Cook <keescook@chromium.org> writes:
> If the compiler didn't support a build mode, the second empty test would
> still trip. This moves it to an "else" test for the non-AUTO modes.
>
> Reported-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> Robert, can you test this fix?
Sure, tested and it works perfectly.
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
And just to be more complete, what happened yesterday was that I wrongly wrote
"CROSS_COMPILER=arm-linux-gnueabi-" and not "CROSS_COMPILE=arm-linux-gnueabi-".
Normally when I do that kind of mistake, I get a gcc error that my architecture
options (-mabi, ...) are not supported. This time I got the stackprotector
thing. The good part is that with your patch I see again the gcc warnings I was
used too :)
Cheers.
--
Robert
PS:
rj@belgarion:~/mio_linux/kernel$ arm-linux-gnueabi-gcc -fstack-protector
arm-linux-gnueabi-gcc: fatal error: no input files
compilation terminated.
prev parent reply other threads:[~2017-10-15 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 3:42 [PATCH] Makefile: Another fix for stackprotector _AUTO mode Kees Cook
2017-10-15 9:05 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87376kok6g.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox