From: "Bjørn Mork" <bjorn@mork.no>
To: Douglas Anderson <dianders@chromium.org>
Cc: Oliver Neukum <oneukum@suse.com>,
groeck@chromium.org, grundler@chromium.org,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped"
Date: Tue, 19 Sep 2017 19:45:58 +0200 [thread overview]
Message-ID: <87377ioa3t.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20170919161522.995-1-dianders@chromium.org> (Douglas Anderson's message of "Tue, 19 Sep 2017 09:15:20 -0700")
Douglas Anderson <dianders@chromium.org> writes:
> Every once in a while when my system is under a bit of stress I see
> some spammy messages show up in my logs that say:
>
> kevent X may have been dropped
>
> As far as I can tell these messages aren't terribly useful.
I agree, FWIW. These messages just confuse users for no purpose at all.
> + /* If work is already started this will mark it to run again when it
> + * finishes; if we already had work pending and it hadn't started
> + * yet then that's fine too.
> + */
> + schedule_work (&dev->kevent);
> + netdev_dbg(dev->net, "kevent %d scheduled\n", work);
Or maybe
if (schedule_work (&dev->kevent))
netdev_dbg(dev->net, "kevent %d scheduled\n", work);
? Not that I think it matters much.
Bjørn
next prev parent reply other threads:[~2017-09-19 17:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 16:15 [RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped" Douglas Anderson
2017-09-19 16:15 ` [RFC PATCH 2/3] usbnet: Avoid potential races in usbnet_deferred_kevent() Douglas Anderson
2017-09-19 20:37 ` Oliver Neukum
2017-09-19 20:51 ` Guenter Roeck
2017-09-20 8:23 ` Oliver Neukum
2017-09-19 20:53 ` Doug Anderson
2017-09-20 8:25 ` Oliver Neukum
2017-09-19 16:15 ` [RFC PATCH 3/3] usbnet: Fix memory leak when rx_submit() fails Douglas Anderson
2017-09-19 17:41 ` Bjørn Mork
2017-09-19 16:43 ` [RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped" Guenter Roeck
2017-09-19 17:45 ` Bjørn Mork [this message]
2017-09-19 20:36 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87377ioa3t.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=grundler@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox