From: Kalle Valo <kvalo@codeaurora.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: davem@davemloft.net, Larry.Finger@lwfinger.net,
chaoming_li@realsil.com.cn, jon.maloy@ericsson.com,
ying.xue@windriver.com, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] net: rsi: netlink: constify genl_ops
Date: Wed, 23 Aug 2017 13:02:49 +0300 [thread overview]
Message-ID: <87378iy52u.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1503482375-19983-4-git-send-email-arvind.yadav.cs@gmail.com> (Arvind Yadav's message of "Wed, 23 Aug 2017 15:29:35 +0530")
Arvind Yadav <arvind.yadav.cs@gmail.com> writes:
> genl_ops are not supposed to change at runtime. All functions
> working with genl_ops provided by <net/genetlink.h> work with
> const genl_ops. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> net/tipc/netlink_compat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Using the prefix "rsi:" looks wrong for this patch.
--
Kalle Valo
next prev parent reply other threads:[~2017-08-23 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 9:59 [PATCH 0/3] constify *_ops Arvind Yadav
2017-08-23 9:59 ` [PATCH 1/3] net: rtlwifi: constify rate_control_ops Arvind Yadav
2017-08-24 9:57 ` [1/3] " Kalle Valo
2017-08-23 9:59 ` [PATCH 2/3] net: rsi: mac80211: constify ieee80211_ops Arvind Yadav
2017-08-23 9:59 ` [PATCH 3/3] net: rsi: netlink: constify genl_ops Arvind Yadav
2017-08-23 10:02 ` Kalle Valo [this message]
2017-08-23 10:05 ` Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87378iy52u.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=arvind.yadav.cs@gmail.com \
--cc=chaoming_li@realsil.com.cn \
--cc=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox