* [PATCH] usb: dwc2: gadget: Use ep->index in conext of FIFO registers
@ 2017-06-29 7:37 Minas Harutyunyan
2017-06-29 7:39 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Minas Harutyunyan @ 2017-06-29 7:37 UTC (permalink / raw)
To: John Youn, Felipe Balbi, Greg Kroah-Hartman, linux-usb,
linux-kernel
Cc: Minas Harutyunyan
It's reverting patch for commit "usb: dwc2: gadget:
use ep->fifo_index in context of FIFO registers".
DTXFSTSn indexation based on EP number not TxFIFO number.
Signed-off-by: Minas Harutyunyan <hminas@synopsys.com>
---
drivers/usb/dwc2/gadget.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 98a4a79e7f6e..34c714de75be 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -526,8 +526,7 @@ static int dwc2_hsotg_write_fifo(struct dwc2_hsotg *hsotg,
return -ENOSPC;
}
} else if (hsotg->dedicated_fifos && hs_ep->index != 0) {
- can_write = dwc2_readl(hsotg->regs +
- DTXFSTS(hs_ep->fifo_index));
+ can_write = dwc2_readl(hsotg->regs + DTXFSTS(hs_ep->index));
can_write &= 0xffff;
can_write *= 4;
@@ -3153,7 +3152,7 @@ static void kill_all_requests(struct dwc2_hsotg *hsotg,
if (!hsotg->dedicated_fifos)
return;
- size = (dwc2_readl(hsotg->regs + DTXFSTS(ep->fifo_index)) & 0xffff) * 4;
+ size = (dwc2_readl(hsotg->regs + DTXFSTS(ep->index)) & 0xffff) * 4;
if (size < ep->fifo_size)
dwc2_hsotg_txfifo_flush(hsotg, ep->fifo_index);
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: dwc2: gadget: Use ep->index in conext of FIFO registers
2017-06-29 7:37 [PATCH] usb: dwc2: gadget: Use ep->index in conext of FIFO registers Minas Harutyunyan
@ 2017-06-29 7:39 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2017-06-29 7:39 UTC (permalink / raw)
To: Minas Harutyunyan, John Youn, Greg Kroah-Hartman, linux-usb,
linux-kernel
Cc: Minas Harutyunyan
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
Hi,
Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> writes:
> It's reverting patch for commit "usb: dwc2: gadget:
> use ep->fifo_index in context of FIFO registers".
> DTXFSTSn indexation based on EP number not TxFIFO number.
>
> Signed-off-by: Minas Harutyunyan <hminas@synopsys.com>
have a look at 'git revert'
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-29 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-29 7:37 [PATCH] usb: dwc2: gadget: Use ep->index in conext of FIFO registers Minas Harutyunyan
2017-06-29 7:39 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox