From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752607AbcHNTaQ (ORCPT ); Sun, 14 Aug 2016 15:30:16 -0400 Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:59942 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752439AbcHNTaO (ORCPT ); Sun, 14 Aug 2016 15:30:14 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 14 Aug 2016 21:30:12 +0200 X-ME-IP: 109.222.82.242 From: Robert Jarzmik To: Hans Verkuil Cc: Mauro Carvalho Chehab , Guennadi Liakhovetski , Jiri Kosina , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v3 12/14] media: platform: pxa_camera: add debug register access References: <1470684652-16295-1-git-send-email-robert.jarzmik@free.fr> <1470684652-16295-13-git-send-email-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Sun, 14 Aug 2016 21:30:12 +0200 Message-ID: <8737m7rvwb.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hans Verkuil writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: >> Add pxa_camera registers access through advanced video debugging. >> +static int pxac_vidioc_g_chip_info(struct file *file, void *fh, >> + struct v4l2_dbg_chip_info *chip) > > You shouldn't need this g_chip_info function, it should be handled automatically > by the v4l2 core. Just drop it. Okay, let me try and rerun v4l-compliance to be sure I'm covered, and stage it afterwards for v4. Cheers. -- Robert