From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315AbcG2BY7 (ORCPT ); Thu, 28 Jul 2016 21:24:59 -0400 Received: from ozlabs.org ([103.22.144.67]:46671 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411AbcG2BY5 (ORCPT ); Thu, 28 Jul 2016 21:24:57 -0400 From: Rusty Russell To: Vegard Nossum , Ingo Molnar , Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Vegard Nossum , "Paul E. McKenney" , Thomas Gleixner , Ingo Molnar Subject: Re: [PATCH] sched/core: add taint on "BUG: sleeping function called from invalid context" In-Reply-To: <1469216762-19626-1-git-send-email-vegard.nossum@oracle.com> References: <1469216762-19626-1-git-send-email-vegard.nossum@oracle.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 29 Jul 2016 10:52:09 +0930 Message-ID: <8737mtz1a6.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vegard Nossum writes: > Seeing this, it occurs to me that we should probably add a taint here: Taint has traditionally meant "the user did something unsupported, take the bug report with a grain of salt". Such as force removing a module. So this seems wrong... Cheers, Rusty. > > BUG: sleeping function called from invalid context at mm/slab.h:388 > in_atomic(): 0, irqs_disabled(): 0, pid: 32211, name: trinity-c3 > Preemption disabled at:[] console_unlock+0x2f7/0x930 > > CPU: 3 PID: 32211 Comm: trinity-c3 Not tainted 4.7.0-rc7+ #19 > ^^^^^^^^^^^ > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Ubuntu-1.8.2-1ubuntu1 04/01/2014 > 0000000000000000 ffff8800b8a17160 ffffffff81971441 ffff88011a3c4c80 > ffff88011a3c4c80 ffff8800b8a17198 ffffffff81158067 0000000000000de6 > ffff88011a3c4c80 ffffffff8390e07c 0000000000000184 0000000000000000 > Call Trace: > [...] > > BUG: sleeping function called from invalid context at arch/x86/mm/fault.c:1309 > in_atomic(): 0, irqs_disabled(): 0, pid: 32211, name: trinity-c3 > Preemption disabled at:[] down_trylock+0x13/0x80 > > CPU: 3 PID: 32211 Comm: trinity-c3 Not tainted 4.7.0-rc7+ #19 > ^^^^^^^^^^^ > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Ubuntu-1.8.2-1ubuntu1 04/01/2014 > 0000000000000000 ffff8800b8a17e08 ffffffff81971441 ffff88011a3c4c80 > ffff88011a3c4c80 ffff8800b8a17e40 ffffffff81158067 0000000000000000 > ffff88011a3c4c80 ffffffff83437b20 000000000000051d 0000000000000000 > Call Trace: > [...] > > Cc: Peter Zijlstra > Cc: Paul E. McKenney > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Rusty Russel > Signed-off-by: Vegard Nossum > --- > kernel/sched/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 97ee9ac..7171cf9 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -7573,6 +7573,7 @@ void ___might_sleep(const char *file, int line, int preempt_offset) > } > #endif > dump_stack(); > + add_taint(TAINT_WARN, LOCKDEP_STILL_OK); > } > EXPORT_SYMBOL(___might_sleep); > #endif > -- > 1.9.1