From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753854AbcFGGyM (ORCPT ); Tue, 7 Jun 2016 02:54:12 -0400 Received: from mga14.intel.com ([192.55.52.115]:5497 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753592AbcFGGyK (ORCPT ); Tue, 7 Jun 2016 02:54:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,432,1459839600"; d="scan'208";a="996728047" From: Jani Nikula To: Vinay Simha BN Cc: Vinay Simha BN , Archit Taneja , John Stultz , Thierry Reding , Sumit Semwal , David Airlie , "open list\:DRM DRIVERS" , open list Subject: Re: [PATCH v2] drm/dsi: Implement set tear scanline In-Reply-To: <1465234897-21365-1-git-send-email-simhavcs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1465234897-21365-1-git-send-email-simhavcs@gmail.com> User-Agent: Notmuch/0.22+12~gbdd9442 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 07 Jun 2016 09:54:06 +0300 Message-ID: <8737op7alt.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 06 Jun 2016, Vinay Simha BN wrote: > Provide a small convenience wrapper that transmits > a set_tear_scanline command. > > Also includes small build fixes from Sumit Semwal. > > Cc: Archit Taneja > Cc: John Stultz > Cc: Thierry Reding > Cc: Sumit Semwal > Cc: Jani Nikula > Signed-off-by: Vinay Simha BN > -- > v1: > * helper function suggested by Thierry > for set_tear_scanline > v2: > * one scanline parameter suggested by jani > --- > drivers/gpu/drm/drm_mipi_dsi.c | 22 ++++++++++++++++++++++ > include/drm/drm_mipi_dsi.h | 1 + > 2 files changed, 23 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index f5d8083..c02d083 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -983,6 +983,28 @@ int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, > EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_on); > > /** > + * mipi_dsi_set_tear_scanline() - turn on the display module's Tearing Effect > + * output signal on the TE signal line when display module reaches line N > + * defined by STS[n:0]. > + * @dsi: DSI peripheral device > + * @param: STS[10:0] > + * Return: 0 on success or a negative error code on failure > + */ > +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, u16 param) > +{ > + u8 payload[3] = { MIPI_DCS_SET_TEAR_SCANLINE, param >> 8, > + param & 0xff }; > + ssize_t err; > + > + err = mipi_dsi_generic_write(dsi, &payload, sizeof(payload)); You can just pass in payload, not &payload. BR, Jani. > + if (err < 0) > + return err; > + > + return 0; > +} > +EXPORT_SYMBOL(mipi_dsi_set_tear_scanline); > + > +/** > * mipi_dsi_dcs_set_pixel_format() - sets the pixel format for the RGB image > * data used by the interface > * @dsi: DSI peripheral device > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 7a9840f..ec55285 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -263,6 +263,7 @@ int mipi_dsi_dcs_set_column_address(struct mipi_dsi_device *dsi, u16 start, > u16 end); > int mipi_dsi_dcs_set_page_address(struct mipi_dsi_device *dsi, u16 start, > u16 end); > +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, u16 param); > int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi); > int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, > enum mipi_dsi_dcs_tear_mode mode); -- Jani Nikula, Intel Open Source Technology Center