From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756916AbcDEFV7 (ORCPT ); Tue, 5 Apr 2016 01:21:59 -0400 Received: from mga03.intel.com ([134.134.136.65]:21220 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbcDEFV6 (ORCPT ); Tue, 5 Apr 2016 01:21:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,442,1455004800"; d="asc'?scan'208";a="948155306" From: Felipe Balbi To: Grygorii Strashko , Greg Kroah-Hartman , linux-usb@vger.kernel.org Cc: Roger Quadros , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nsekhar@ti.com, Murali Karicheri Subject: Re: [PATCH] usb: dwc3: keystone: drop dma_mask configuration In-Reply-To: <57026F02.4060300@ti.com> References: <1459769611-16862-1-git-send-email-grygorii.strashko@ti.com> <87pou561i5.fsf@intel.com> <57026F02.4060300@ti.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Tue, 05 Apr 2016 08:19:40 +0300 Message-ID: <8737r0639v.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Grygorii Strashko writes: > On 04/04/2016 02:45 PM, Felipe Balbi wrote: >> >> Hi, >> >> Grygorii Strashko writes: >>> The Keystone 2 supports DT-boot only, as result dma_mask will be >>> always configured properly from DT - >>> of_platform_device_create_pdata()->of_dma_configure(). More over, >>> dwc3-keystone.c can be built as module and in this case it's unsafe to >>> assign local variable as dma_mask. >>> >>> Hence, remove dma_mask configuration code. >>> >>> Cc: Murali Karicheri >>> Signed-off-by: Grygorii Strashko >> >> with these two patches from you, does USB Peripheral work on k2 devices ? > > I've tried CONFIG_USB_DWC3_GADGET=3Dy + g_zero and k2e was detected > as gzero dev from Host PC > >> >> I'll drop my k2 changes from my series which I sent on saturday. >> > > Yes, please. can you test a similar patch to dwc3-omap.c, then ? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXA0rtAAoJEIaOsuA1yqREG5IQALHfN60fK60GhECWTsawMc5D REjfv5HIp/jtJl4XPdIvYCTM940/D3x0ZnZMH7VZuFO5Qz9epG7Wf689aY9A2Ybp tu+sq41sM4OqzZQl5rNGHC2LJ4zam3J13uBk39VTeVTbQ/Jr7IN3J/I0lXmJ4Rle GAFSowkIm0EAWlykTVFMKbHh2xtxaz4U1/HjrIbP3ziLxOtJOYszZthxerjEdQtd GyWQK0v5qEuQOk1TbilcnCv/FgBXZ6cTmUEMP/542A8l/7uarWlnK3YkI3OU9tR9 37b8xNXUCaRe1XogyeE5z2L5PtxuptUIXcyyz/TPpy/oyijeM+9xw41HOOMzZtXC s8O9hlgIkYAZbdSKA7S5U/lhz9mCuoX3uI7cQSPCkvMU94dUCijsKYOcwGUNfRTN gMSnW78GiYnpjaJSTWVKsvMnV5d7juPb31UJUxvNMbXQ/G9lwfIZYsAtpj8CCD8d B0tiF0bcL4/lz/ZPU1hOLNyNUMJGczFGVTj+0z4XBGiwfczb/9fJ0GQxsTCRHCTY DEMnbdeYTXoLRMEMt8ligfpKAdSh/Z9VbC4F+8eQCbu6M+aylSPm5/oCIa7EHAUk V2YcSjZMmXsE9s2i1M0Ig/f9NkianWOwoK3Ut9u8blUOQHCjGlY8ouqOnNMchzy6 80YXuVgOaEYsuZArCYaM =EYzH -----END PGP SIGNATURE----- --=-=-=--