From: Felipe Balbi <balbi@ti.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
David Cohen <david.a.cohen@linux.intel.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] usb: pci-quirks: register USB mux found on Cherrytrail SOC
Date: Wed, 2 Dec 2015 08:46:53 -0600 [thread overview]
Message-ID: <8737vksyaq.fsf@saruman.tx.rr.com> (raw)
In-Reply-To: <20151202091324.GA7587@kuha.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
Hi,
Heikki Krogerus <heikki.krogerus@linux.intel.com> writes:
> Hi Felipe,
>
>> IMHO, this should be creating a child device instead of calling
>> intel_usb_mux_register() directly. That way, your mux driver could
>> actually _be_ a driver. Seems like all you need to do from this point is
>> a register a simple platform_device which is a child of xhci, see
>> platform_device_register_simple() for how to do this.
>>
>> Or rather, platform_device_register_rsndata() passing xhci's device
>> pointer as parent.
>
> That was the plan originally, but unfortunately it does not work in
> this case. It creates conflict as platform_device_add() call will then
> claim part of io memory belonging to xHCI, making xHCI fail to probe.
okay, understood.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-12-02 14:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 13:32 [PATCH 0/2] extcon: driver for Intel USB MUX Heikki Krogerus
2015-12-01 13:32 ` [PATCH 1/2] extcon: add driver for Intel USB mux Heikki Krogerus
2015-12-01 20:28 ` David Cohen
2015-12-02 10:27 ` Heikki Krogerus
2015-12-02 18:17 ` David Cohen
2015-12-01 20:34 ` Felipe Balbi
2015-12-01 20:55 ` David Cohen
2015-12-01 21:22 ` Felipe Balbi
2015-12-01 13:32 ` [PATCH 2/2] usb: pci-quirks: register USB mux found on Cherrytrail SOC Heikki Krogerus
2015-12-01 20:38 ` Felipe Balbi
2015-12-02 9:13 ` Heikki Krogerus
2015-12-02 14:46 ` Felipe Balbi [this message]
2015-12-02 7:02 ` Lu Baolu
2015-12-02 9:15 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737vksyaq.fsf@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=baolu.lu@linux.intel.com \
--cc=cw00.choi@samsung.com \
--cc=david.a.cohen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox