From: Eric Anholt <eric@anholt.net>
To: Luis de Bethencourt <luis@debethencourt.com>,
linux-kernel@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@the-dreams.de>,
alsa-devel@alsa-project.org,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers
Date: Wed, 14 Oct 2015 17:44:46 -0700 [thread overview]
Message-ID: <8737xdgdtt.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20150827150401.GA32653@goodgumbo.baconseed.org>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
Luis de Bethencourt <luis@debethencourt.com> writes:
> These platform drivers have a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
> sound/soc/bcm/bcm2835-i2s.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c
> index 03fa1cb..8c435be 100644
> --- a/sound/soc/bcm/bcm2835-i2s.c
> +++ b/sound/soc/bcm/bcm2835-i2s.c
> @@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = {
> {},
> };
>
> +MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
> +
> static struct platform_driver bcm2835_i2s_driver = {
> .probe = bcm2835_i2s_probe,
> .driver = {
> --
It looks like this should go through the asoc tree, but I don't see it
in there.
FWIW, it is also:
Acked-by: Eric Anholt <eric@anholt.net>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-10-15 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 15:04 [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers Luis de Bethencourt
2015-09-02 9:21 ` Lee Jones
2015-10-15 0:44 ` Eric Anholt [this message]
2015-10-15 12:36 ` Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737xdgdtt.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=luis@debethencourt.com \
--cc=perex@perex.cz \
--cc=swarren@wwwdotorg.org \
--cc=tiwai@suse.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox