From: ebiederm@xmission.com (Eric W. Biederman)
To: Shailendra Verma <shailendra.capricorn@gmail.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Fabian Frederick <fabf@skynet.be>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel:user_namespace - Fix for typos in comments.
Date: Sat, 23 May 2015 13:02:52 -0500 [thread overview]
Message-ID: <87382n2mur.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <1432357647-4135-1-git-send-email-shailendra.capricorn@gmail.com> (Shailendra Verma's message of "Sat, 23 May 2015 10:37:27 +0530")
Shailendra Verma <shailendra.capricorn@gmail.com> writes:
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
> kernel/user_namespace.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c
> index 4109f83..02a1197 100644
> --- a/kernel/user_namespace.c
> +++ b/kernel/user_namespace.c
> @@ -69,7 +69,7 @@ int create_user_ns(struct cred *new)
> /*
> * Verify that we can not violate the policy of which files
> * may be accessed that is specified by the root directory,
> - * by verifing that the root directory is at the root of the
> + * by verifying that the root directory is at the root of the
> * mount namespace which allows all files to be accessed.
> */
> if (current_chrooted())
> @@ -617,7 +617,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
> *
> * There is a one time data dependency between reading the
> * count of the extents and the values of the extents. The
> - * desired behavior is to see the values of the extents that
^^^^^^^^ In american englic behavior is a correct spelling.
I don't know why the brits throw in extraneous letters.
> + * desired behaviour is to see the values of the extents that
> * were written before the count of the extents.
> *
> * To achieve this smp_wmb() is used on guarantee the write
> @@ -716,7 +716,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
> (next_line != NULL))
> goto out;
> }
> - /* Be very certaint the new map actually exists */
> + /* Be very certain the new map actually exists */
> if (new_map.nr_extents == 0)
> goto out;
>
> @@ -841,7 +841,7 @@ static bool new_idmap_permitted(const struct file *file,
>
> /* Allow the specified ids if we have the appropriate capability
> * (CAP_SETUID or CAP_SETGID) over the parent user namespace.
> - * And the opener of the id file also had the approprpiate capability.
> + * And the opener of the id file also had the appropriate capability.
> */
> if (ns_capable(ns->parent, cap_setid) &&
> file_ns_capable(file, ns->parent, cap_setid))
next prev parent reply other threads:[~2015-05-23 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-23 5:07 [PATCH] kernel:user_namespace - Fix for typos in comments Shailendra Verma
2015-05-23 18:02 ` Eric W. Biederman [this message]
2015-05-29 0:09 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87382n2mur.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=shailendra.capricorn@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox