From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Hans Wennborg <hans@hanshq.net>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <ath6kl@lists.infradead.org>
Subject: Re: [PATCH 10/19] ath6kl: fix %d confusingly prefixed with 0x in format strings
Date: Thu, 14 Aug 2014 15:38:54 +0300 [thread overview]
Message-ID: <8738czmejl.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1407111596-14944-1-git-send-email-hans@hanshq.net> (Hans Wennborg's message of "Sun, 3 Aug 2014 17:19:56 -0700")
Hans Wennborg <hans@hanshq.net> writes:
> Signed-off-by: Hans Wennborg <hans@hanshq.net>
> ---
> drivers/net/wireless/ath/ath6kl/init.c | 2 +-
> drivers/net/wireless/ath/ath6kl/main.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
> index fffd523..91af845 100644
> --- a/drivers/net/wireless/ath/ath6kl/init.c
> +++ b/drivers/net/wireless/ath/ath6kl/init.c
> @@ -1049,7 +1049,7 @@ static int ath6kl_fetch_fw_apin(struct ath6kl *ar, const char *name)
> ar->hw.reserved_ram_size = le32_to_cpup(val);
>
> ath6kl_dbg(ATH6KL_DBG_BOOT,
> - "found reserved ram size ie 0x%d\n",
> + "found reserved ram size ie 0x%x\n",
> ar->hw.reserved_ram_size);
Actually the original intent here was to use %d.
> diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c
> index 21516bc..933aef0 100644
> --- a/drivers/net/wireless/ath/ath6kl/main.c
> +++ b/drivers/net/wireless/ath/ath6kl/main.c
> @@ -225,7 +225,7 @@ int ath6kl_diag_write32(struct ath6kl *ar, u32 address, __le32 value)
> ret = ath6kl_hif_diag_write32(ar, address, value);
>
> if (ret) {
> - ath6kl_err("failed to write 0x%x during diagnose window to 0x%d\n",
> + ath6kl_err("failed to write 0x%x during diagnose window to 0x%x\n",
> address, value);
This is ok.
--
Kalle Valo
next prev parent reply other threads:[~2014-08-14 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 0:19 [PATCH 10/19] ath6kl: fix %d confusingly prefixed with 0x in format strings Hans Wennborg
2014-08-14 12:38 ` Kalle Valo [this message]
2014-08-17 21:57 ` [PATCH 1/1] " Hans Wennborg
2014-08-25 8:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738czmejl.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl@lists.infradead.org \
--cc=hans@hanshq.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox