From: Chris Ball <cjb@laptop.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Grant Grundler <grundler@chromium.org>,
Seungwon Jeon <tgih.jun@samsung.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: core: remove issue_fn indirect function call
Date: Wed, 25 Sep 2013 22:37:30 -0400 [thread overview]
Message-ID: <8738os2tqt.fsf@octavius.laptop.org> (raw)
In-Reply-To: <87fvss2uh9.fsf@octavius.laptop.org> (Chris Ball's message of "Wed, 25 Sep 2013 22:21:38 -0400")
Hi,
On Wed, Sep 25 2013, Chris Ball wrote:
> Hi,
>
> On Fri, Sep 20 2013, Ulf Hansson wrote:
>> On 19 September 2013 19:20, Grant Grundler <grundler@chromium.org> wrote:
>>> struct mmc_queue defines issue_fn as an indirect function call.
>>> issue_fn field only gets set to mmc_blk_issue_rq and only gets
>>> invoked immediately after calling blk_fetch_request().
>>> Don't bother with indirect function call - it's pointless and just
>>> obfuscates the code.
>>>
>>> Signed-off-by: Grant Grundler <grundler@chromium.org>
>>
>> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Thanks, pushed to mmc-next for 3.13.
Have dropped this, it's breaking my build:
/home/cjb/git/mmc/drivers/mmc/card/block.c:1955:12: warning: ‘mmc_blk_issue_rq’ defined but not used [-Wunused-function]
/home/cjb/git/mmc/drivers/mmc/card/queue.c: In function ‘mmc_queue_thread’:
/home/cjb/git/mmc/drivers/mmc/card/queue.c:70:4: error: implicit declaration of function ‘mmc_blk_issue_rq’ [-Werror=implicit-function-declaration]
Grant, please could you take a look and resubmit?
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
next prev parent reply other threads:[~2013-09-26 2:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 17:20 [PATCH] mmc: core: remove issue_fn indirect function call Grant Grundler
2013-09-20 7:33 ` Ulf Hansson
2013-09-26 2:21 ` Chris Ball
2013-09-26 2:37 ` Chris Ball [this message]
2013-09-26 21:56 ` Grant Grundler
2013-09-26 22:16 ` Grant Grundler
2013-09-27 9:04 ` Ulf Hansson
2013-09-27 22:36 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738os2tqt.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=grundler@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox