Re: The bug of iput() removal from flusher thread?

[OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>]

OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:

> Hi,
>
> In 169ebd90131b2ffca74bb2dbe7eeacd39fb83714 commit, writeback doesn't
> __iget()/iput() anymore.
>
> This means nobody moves the inode to lru list. I.e.
>
> 	new_inode()
> 	dirty_inode()
> 	iput_final()
> 		/* keep inode without adding lru */
> 	flush indoes
>         /* clean inode is not on lru */
>
> I noticed this situation in my FS though, I think the same bug is on all
> FSes of linus tree too, after this commit.
>
> Am I missing the something?

This seems to be reproducible by the following,

#!/bin/sh

for i in $(seq -w 1000); do
	for j in $(seq -w 1000); do
        	for k in $(seq -w 1000); do
                	mkdir -p $i/$j
                        echo $i/$j/$k > $i/$j/$k
                        echo 2 > /proc/sys/vm/drop_caches
                done
        done
done

Some inodes never be reclaimed, and ls -l frees those inodes (stat(2)
does iget/iput).
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>