From: Namhyung Kim <namhyung@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaud Lacombe <lacombar@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
David Miller <davem@davemloft.net>,
namhyung.kim@lge.com, a.p.zijlstra@chello.nl, paulus@samba.org,
mingo@redhat.com, acme@ghostprotocols.net,
linux-kernel@vger.kernel.org
Subject: Re: [patch] perf: Fix build failure on OpenSuse userspace
Date: Sat, 05 May 2012 00:26:18 +0900 [thread overview]
Message-ID: <87397gx90l.fsf@gmail.com> (raw)
In-Reply-To: <20120504150211.GA2995@m.brq.redhat.com> (Jiri Olsa's message of "Fri, 4 May 2012 17:02:11 +0200")
Hi,
On Fri, 4 May 2012 17:02:11 +0200, Jiri Olsa wrote:
>> So I doubt -Wno-unused-parameter will do any good here.
> I think we need also -Wno-sign-compare, please check the attached patch
>
>
> ---
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 7055a00..8f7b6cf 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -729,10 +729,10 @@ $(OUTPUT)perf.o perf.spec \
> # over the general rule for .o
>
> $(OUTPUT)util/%-flex.o: $(OUTPUT)util/%-flex.c $(OUTPUT)PERF-CFLAGS
> - $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) -Iutil/ -Wno-redundant-decls -Wno-switch-default -Wno-unused-function $<
> + $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) -Iutil/ -Wno-redundant-decls -Wno-switch-default -Wno-unused-function -Wno-unused-parameter -Wno-sign-compare $<
>
s/unused-parameter/unused-result/ ?
Thanks,
Namhyung
> $(OUTPUT)util/%-bison.o: $(OUTPUT)util/%-bison.c $(OUTPUT)PERF-CFLAGS
> - $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -Iutil/ -Wno-redundant-decls -Wno-switch-default -Wno-unused-function $<
> + $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -Iutil/ -Wno-redundant-decls -Wno-switch-default -Wno-unused-function -Wno-unused-parameter -Wno-sign-compare $<
>
> $(OUTPUT)%.o: %.c $(OUTPUT)PERF-CFLAGS
> $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) $<
next prev parent reply other threads:[~2012-05-04 15:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 21:57 perf build failure on Linus's tree Greg KH
2012-05-04 1:37 ` Namhyung Kim
2012-05-04 1:41 ` Greg KH
2012-05-04 1:45 ` Namhyung Kim
2012-05-04 1:50 ` David Miller
2012-05-04 2:14 ` Arnaud Lacombe
2012-05-04 2:24 ` Namhyung Kim
2012-05-04 2:29 ` Arnaud Lacombe
2012-05-04 2:35 ` Arnaud Lacombe
2012-05-04 2:47 ` Greg KH
2012-05-04 3:01 ` Arnaud Lacombe
2012-05-04 3:16 ` Greg KH
2012-05-04 4:01 ` Arnaud Lacombe
2012-05-04 7:09 ` [patch] perf: Fix build failure on OpenSuse userspace Ingo Molnar
2012-05-04 14:44 ` Arnaud Lacombe
2012-05-04 14:55 ` Namhyung Kim
2012-05-04 15:09 ` Greg KH
2012-05-04 15:02 ` Jiri Olsa
2012-05-04 15:26 ` Namhyung Kim [this message]
2012-05-04 15:03 ` Arnaldo Carvalho de Melo
2012-05-04 14:52 ` Greg KH
2012-05-04 15:10 ` Lucas De Marchi
2012-05-04 15:26 ` Jiri Olsa
2012-05-04 15:38 ` Namhyung Kim
2012-05-04 16:41 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87397gx90l.fsf@gmail.com \
--to=namhyung@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jolsa@redhat.com \
--cc=lacombar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox