[PATCHv3] OMAP: Enable Magic SysRq on serial console ttyOx

[PATCHv3] OMAP: Enable Magic SysRq on serial console ttyOx

[Thomas Weber]

Magic SysRq key is not working for OMAP on new serial
console ttyOx because SUPPORT_SYSRQ is not defined
for omap-serial.

This patch defines SUPPORT_SYSRQ in omap-serial and
enables handling of Magic SysRq character.

Further there is an issue of losing first break character.
Removing the reset of the lsr_break_flag fixes this issue.

Signed-off-by: Thomas Weber <weber@corscience.de>
---
 drivers/serial/omap-serial.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/omap-serial.c b/drivers/serial/omap-serial.c
index 7f2f010..699b344 100644
--- a/drivers/serial/omap-serial.c
+++ b/drivers/serial/omap-serial.c
@@ -20,6 +20,10 @@
  * this driver as required for the omap-platform.
  */
 
+#if defined(CONFIG_SERIAL_OMAP_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
+#define SUPPORT_SYSRQ
+#endif
+
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/console.h>
@@ -190,7 +194,6 @@ static inline void receive_chars(struct uart_omap_port *up, int *status)
 			if (up->port.line == up->port.cons->index) {
 				/* Recover the break flag from console xmit */
 				lsr |= up->lsr_break_flag;
-				up->lsr_break_flag = 0;
 			}
 #endif
 			if (lsr & UART_LSR_BI)
-- 
1.7.4.rc2

Re: [PATCHv3] OMAP: Enable Magic SysRq on serial console ttyOx

[Govindraj]

On Fri, Jan 21, 2011 at 3:31 PM, Thomas Weber <weber@corscience.de> wrote:
> Magic SysRq key is not working for OMAP on new serial
> console ttyOx because SUPPORT_SYSRQ is not defined
> for omap-serial.
>
> This patch defines SUPPORT_SYSRQ in omap-serial and
> enables handling of Magic SysRq character.
>
> Further there is an issue of losing first break character.
> Removing the reset of the lsr_break_flag fixes this issue.
>
> Signed-off-by: Thomas Weber <weber@corscience.de>


Acked-by: Govindraj.R <govindraj.raja@ti.com>
Tested-by: Manjunath G Kondaiah <manjugk@ti.com>


> ---
>  drivers/serial/omap-serial.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/serial/omap-serial.c b/drivers/serial/omap-serial.c
> index 7f2f010..699b344 100644
> --- a/drivers/serial/omap-serial.c
> +++ b/drivers/serial/omap-serial.c
> @@ -20,6 +20,10 @@
>  * this driver as required for the omap-platform.
>  */
>
> +#if defined(CONFIG_SERIAL_OMAP_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
> +#define SUPPORT_SYSRQ
> +#endif
> +
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/console.h>
> @@ -190,7 +194,6 @@ static inline void receive_chars(struct uart_omap_port *up, int *status)
>                        if (up->port.line == up->port.cons->index) {
>                                /* Recover the break flag from console xmit */
>                                lsr |= up->lsr_break_flag;
> -                               up->lsr_break_flag = 0;
>                        }
>  #endif
>                        if (lsr & UART_LSR_BI)
> --
> 1.7.4.rc2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: [PATCHv3] OMAP: Enable Magic SysRq on serial console ttyOx

[Kevin Hilman]

Govindraj <govindraj.ti@gmail.com> writes:

> On Fri, Jan 21, 2011 at 3:31 PM, Thomas Weber <weber@corscience.de> wrote:
>> Magic SysRq key is not working for OMAP on new serial
>> console ttyOx because SUPPORT_SYSRQ is not defined
>> for omap-serial.
>>
>> This patch defines SUPPORT_SYSRQ in omap-serial and
>> enables handling of Magic SysRq character.
>>
>> Further there is an issue of losing first break character.
>> Removing the reset of the lsr_break_flag fixes this issue.
>>
>> Signed-off-by: Thomas Weber <weber@corscience.de>
>
>
> Acked-by: Govindraj.R <govindraj.raja@ti.com>
> Tested-by: Manjunath G Kondaiah <manjugk@ti.com>
>

Acked-by: Kevin Hilman <khilman@ti.com>

Greg, this one should go for .38-rc.   Feel free to merge, or we can
take it through the OMAP tree with your ack.

Thanks,

Kevin

Re: [PATCHv3] OMAP: Enable Magic SysRq on serial console ttyOx

[Thomas Weber]

On Mon, Jan 24, 2011 at 10:47 PM, Kevin Hilman <khilman@ti.com> wrote:
> Govindraj <govindraj.ti@gmail.com> writes:
>
>> On Fri, Jan 21, 2011 at 3:31 PM, Thomas Weber <weber@corscience.de> wrote:
>>> Magic SysRq key is not working for OMAP on new serial
>>> console ttyOx because SUPPORT_SYSRQ is not defined
>>> for omap-serial.
>>>
>>> This patch defines SUPPORT_SYSRQ in omap-serial and
>>> enables handling of Magic SysRq character.
>>>
>>> Further there is an issue of losing first break character.
>>> Removing the reset of the lsr_break_flag fixes this issue.
>>>
>>> Signed-off-by: Thomas Weber <weber@corscience.de>
>>
>>
>> Acked-by: Govindraj.R <govindraj.raja@ti.com>
>> Tested-by: Manjunath G Kondaiah <manjugk@ti.com>
>>
>
> Acked-by: Kevin Hilman <khilman@ti.com>
>
> Greg, this one should go for .38-rc.   Feel free to merge, or we can
> take it through the OMAP tree with your ack.
>
> Thanks,
>
> Kevin
>
> --

Hello,
should I rebase this patch, because it does not apply after movement
of driver/serial to driver/tty/serial?

Thomas

Re: [PATCHv3] OMAP: Enable Magic SysRq on serial console ttyOx

[Kevin Hilman]

Thomas Weber <thomas.weber.linux@googlemail.com> writes:

> On Mon, Jan 24, 2011 at 10:47 PM, Kevin Hilman <khilman@ti.com> wrote:
>> Govindraj <govindraj.ti@gmail.com> writes:
>>
>>> On Fri, Jan 21, 2011 at 3:31 PM, Thomas Weber <weber@corscience.de> wrote:
>>>> Magic SysRq key is not working for OMAP on new serial
>>>> console ttyOx because SUPPORT_SYSRQ is not defined
>>>> for omap-serial.
>>>>
>>>> This patch defines SUPPORT_SYSRQ in omap-serial and
>>>> enables handling of Magic SysRq character.
>>>>
>>>> Further there is an issue of losing first break character.
>>>> Removing the reset of the lsr_break_flag fixes this issue.
>>>>
>>>> Signed-off-by: Thomas Weber <weber@corscience.de>
>>>
>>>
>>> Acked-by: Govindraj.R <govindraj.raja@ti.com>
>>> Tested-by: Manjunath G Kondaiah <manjugk@ti.com>
>>>
>>
>> Acked-by: Kevin Hilman <khilman@ti.com>
>>
>> Greg, this one should go for .38-rc.   Feel free to merge, or we can
>> take it through the OMAP tree with your ack.
>>
>> Thanks,
>>
>> Kevin
>>
>> --
>
> Hello,
> should I rebase this patch, because it does not apply after movement
> of driver/serial to driver/tty/serial?
>

Yes, please rebase.

Thanks,

Kevin