public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: x86's nmi_hz wrt. oprofile's nmi_timer_int.c
Date: Sun, 22 Feb 2009 18:06:45 +0100	[thread overview]
Message-ID: <873ae6wgd6.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20090129.155852.161923905.davem@davemloft.net> (David Miller's message of "Thu, 29 Jan 2009 15:58:52 -0800 (PST)")

David Miller <davem@davemloft.net> writes:

Really old mail, but I was very behind. I didn't see an 
correct answer, so let's answer it.

> While working on an NMI watchdog implementation on sparc64
> I noticed what seems to be a peculiar behavior of the NMI
> timer int oprofile support on x86.
>
> When the NMI watchdog tests itself at boot timer we start
> with nmi_hz equal to HZ.
>
> After the NMI watchdog self-test passes, nmi_hz is reduced
> down to '1'.
>
> The NMI timer int oprofile support simply uses DIE_NMI notifiers for
> it's implementation.  But I don't see anything in the code of
> arch/x86/oprofile/nmi_timer_int.c nor the NMI watchdog infrastructure
> which will re-adjust nmi_hz back to HZ or something similar.
>
> Am I missing something?

oprofile generates its own NMIs, it does not rely on 
the ones from the nmi watchdog.

In timer mode it does not use nmis or die notifiers, but relies on the 
regular non nmi timer interrupt.

Does that answer your question?

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.

  parent reply	other threads:[~2009-02-22 17:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-29 23:58 x86's nmi_hz wrt. oprofile's nmi_timer_int.c David Miller
2009-01-30 15:01 ` Ingo Molnar
2009-01-30 21:54   ` David Miller
2009-02-02 23:14     ` David Miller
2009-02-03 12:27       ` Ingo Molnar
2009-02-22 17:06 ` Andi Kleen [this message]
2009-02-23  4:11   ` David Miller
2009-02-23  4:52     ` Andi Kleen
2009-02-23  5:59       ` David Miller
2009-02-23  6:34         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873ae6wgd6.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox